From: Fiona Ebner <f.ebner@proxmox.com>
To: qemu-devel@nongnu.org
Cc: kraxel@redhat.com, m.frank@proxmox.com,
marcandre.lureau@redhat.com, berrange@redhat.com,
mcascell@redhat.com, qemu-stable@nongnu.org
Subject: Re: [PATCH] ui/clipboard: avoid crash upon request when clipboard peer is not initialized
Date: Fri, 12 Jan 2024 15:11:52 +0100 [thread overview]
Message-ID: <00443ef8-567d-4d18-ad59-08b19e4d7c13@proxmox.com> (raw)
In-Reply-To: <20240112135527.57212-1-f.ebner@proxmox.com>
Am 12.01.24 um 14:55 schrieb Fiona Ebner:
>
> Then when noVNC sends a VNC_MSG_CLIENT_CUT_TEXT message (it did set
> the feature correctly, so the check added by your patch passes),
Sorry, forgot to adapt this part. This should read "it did set the
VNC_FEATURE_CLIPBOARD_EXT feature correctly, so a check for it passes".
> that
> clipboard info is passed to qemu_clipboard_request() and the original
> segfault still happens.
>
next prev parent reply other threads:[~2024-01-12 14:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-12 13:55 [PATCH] ui/clipboard: avoid crash upon request when clipboard peer is not initialized Fiona Ebner
2024-01-12 14:11 ` Fiona Ebner [this message]
2024-01-14 13:51 ` Marc-André Lureau
2024-01-15 10:44 ` Fiona Ebner
2024-01-15 11:15 ` Marc-André Lureau
2024-01-15 11:26 ` Fiona Ebner
2024-01-15 11:33 ` Marc-André Lureau
2024-01-15 11:48 ` Fiona Ebner
2024-01-15 12:00 ` Marc-André Lureau
2024-01-16 12:11 ` Fiona Ebner
2024-01-17 10:59 ` Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00443ef8-567d-4d18-ad59-08b19e4d7c13@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=berrange@redhat.com \
--cc=kraxel@redhat.com \
--cc=m.frank@proxmox.com \
--cc=marcandre.lureau@redhat.com \
--cc=mcascell@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).