From: "Pavel Dovgalyuk" <dovgaluk@ispras.ru>
To: 'Paolo Bonzini' <pbonzini@redhat.com>,
'Artem Pisarenko' <artem.k.pisarenko@gmail.com>,
'Clement Deschamps' <clement.deschamps@greensocs.com>,
alex.bennee@linaro.org
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Revert "icount: remove obsolete warp call"
Date: Wed, 17 Oct 2018 14:43:38 +0300 [thread overview]
Message-ID: <004601d4660e$a54a6b00$efdf4100$@ru> (raw)
In-Reply-To: <a29da0a1-85d7-c57c-5c42-27594a7849ac@redhat.com>
> From: Paolo Bonzini [mailto:pbonzini@redhat.com]
> On 17/10/2018 13:38, Pavel Dovgalyuk wrote:
> >> From: Paolo Bonzini [mailto:pbonzini@redhat.com]
> >> On 17/10/2018 11:53, Artem Pisarenko wrote:
> >>> See my last comment in bug report. This kind of modification, even
> >>> adapted to changed function name, doesn't solve issue.
> >>> I thought long time that it does, but once I catched qemu with a hang.
> >>> And of course, I wasn't able to reproduce it. So it just better hides issue.
> >>> Take a look at alternative solution from
> >>> QBox: https://git.greensocs.com/qemu/qbox/commit/a8ed106032e375e715a531d6e93e4d9ec295dbdb
> >>> I didn't catched fail with it (yet).
> >
> > Tried to test it, but rr seems to be broken again.
> > I'll try to bisect now.
>
> Can we add a test that runs with "make check" and covers the basics of
> record/replay's cpus.c bits?
I thought Alex is trying to create some tests.
Alex, am I right?
Pavel Dovgalyuk
next prev parent reply other threads:[~2018-10-17 11:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-17 9:07 [Qemu-devel] [PATCH] Revert "icount: remove obsolete warp call" Paolo Bonzini
2018-10-17 9:37 ` Pavel Dovgalyuk
2018-10-17 9:53 ` Artem Pisarenko
2018-10-17 10:17 ` Paolo Bonzini
2018-10-17 11:38 ` Pavel Dovgalyuk
2018-10-17 11:42 ` Paolo Bonzini
2018-10-17 11:43 ` Pavel Dovgalyuk [this message]
2018-10-17 12:30 ` Alex Bennée
2018-10-17 12:11 ` Pavel Dovgalyuk
2018-10-17 13:20 ` Pavel Dovgalyuk
2018-10-17 13:32 ` Artem Pisarenko
2018-10-18 5:49 ` Pavel Dovgalyuk
2018-10-17 14:43 ` Paolo Bonzini
2018-10-18 2:22 ` Clement Deschamps
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='004601d4660e$a54a6b00$efdf4100$@ru' \
--to=dovgaluk@ispras.ru \
--cc=alex.bennee@linaro.org \
--cc=artem.k.pisarenko@gmail.com \
--cc=clement.deschamps@greensocs.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).