From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Lcevy-0004yh-As
	for qemu-devel@nongnu.org; Thu, 26 Feb 2009 07:01:46 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Lcevw-0004yM-AI
	for qemu-devel@nongnu.org; Thu, 26 Feb 2009 07:01:45 -0500
Received: from [199.232.76.173] (port=49297 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Lcevw-0004yJ-5F
	for qemu-devel@nongnu.org; Thu, 26 Feb 2009 07:01:44 -0500
Received: from spsmtp02oc.mail2world.com ([74.202.142.148]:4191)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <tobbe.tt@home.se>) id 1Lcevv-0007Su-2P
	for qemu-devel@nongnu.org; Thu, 26 Feb 2009 07:01:43 -0500
From: =?iso-8859-1?Q?Torbj=F6rn_Andersson?= <tobbe.tt@home.se>
References: <20090226093640.GA413@shareable.org>
In-Reply-To: <20090226093640.GA413@shareable.org>
Subject: RE: [Qemu-devel] Machine description, an alternativ using XML
Date: Thu, 26 Feb 2009 13:01:38 +0100
Message-ID: <004d01c99809$fbcacf70$f3606e50$@tt@home.se>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Language: sv
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Jamie Lokier Wrote:
> -----Ursprungligt meddelande-----
> Fr=E5n: qemu-devel-bounces+tobbe.tt=3Dhome.se@nongnu.org [mailto:qemu-
> devel-bounces+tobbe.tt=3Dhome.se@nongnu.org] F=F6r Jamie Lokier
> Skickat: den 26 februari 2009 10:37
> Till: qemu-devel@nongnu.org
> =C4mne: Re: [Qemu-devel] Machine description, an alternativ using XML
>=20
> Torbj=F6rn Andersson wrote:
> > <MACHINE name=3DARM-INTEGRATOR>
> >   <OBJECT name=3D"cpu" class=3D"ARM926ej">
> >     <ATTRIBUTE name=3D"mhz">	<value integer=3D"208"/>  </ATTRIBUTE>
> >     <ATTRIBUTE name=3D"dtcm_size">	<value integer=3D"8192"/>
> </ATTRIBUTE>
> > 	<snipp...>
> >     <ATTRIBUTE name=3D"memmap">	<value obj_ref=3D":memmap"/>
> </ATTRIBUTE>
> >   </OBJECT>
> >   <OBJECT name=3D"memmap" class=3D"MEMMAP">
> >   </OBJECT>
> >     ....
> >   <OBJECT name=3D"pic" class=3D"pl190">
> >     <ATTRIBUTE name=3D"pic">	<value obj_ref=3D":cpu"/>  </ATTRIBUTE>
> >     <ATTRIBUTE name=3D"memmap">	<value obj_ref=3D":memmap"/>
> </ATTRIBUTE>
> >     <ATTRIBUTE name=3D"base">	<value integer=3D"0xc0010000"/>
> </ATTRIBUTE>
> >   </OBJECT>
> > <MACHINE/>
>=20
> Why so verbose?
>=20
> <machine name=3D"arm-integrator">
>   <cpu name=3D"cpu0" type=3D"ARM926ej">
>      <clock mhz=3D"208"/>
>      <dtcm_size>8192</dtcm_size>
>      <memmap ref=3D"memmap0"/>
>   </cpu>
>   <memmap name=3D"memmap0"/>
>   <pic name=3D"pic" type=3D"pl190">
>      <memmap ref=3D"memmap0"/>
>      <cpu ref=3D"cpu0"/>
>      <base>0xc0010000</base>
>   </pic>
> </machine>

We aimed for not putting any aditional burdon on QEMU, by defining =
concepts
like PIC and MEMMAP. Simply Objects and Classes should exist. Then we =
added
MACHINES and CLUSTERS as types in the XML files.

>=20
> > I know you are looking at a solution based on FDT. My belief is that
> the XML
> > solution is more flexible, but I admit that I know very little about
> FDT.
> > Further, I believe that one can create FDTs, from the XML machine
> > definitions, in runtime and pass them to the target-os if required.
> >
> > The strong point with the XML solution is that it is very suitable
> for
> > modeling embedded systems where lots of GPIOs, interrupts, dma-
> channels,
> > i2c, spi, i2s/pcm etc.
>=20
> Isn't FDT capable of that too?

I happy to see Liu Yu FDT for MPC8544DS. I will study it to see if it =
fits
our needs/requirements. My targets are highly complex with lots of
connections between my objects.=20

An example, interrupt lines need to be defined as a pair <object,pin>,
because the interrupt routing might be more complex. Think of a system =
with
cascade connected pl190's. How does one define this relationship in FDT?

<OBJECT usb class=3D"xxx">=20
<!--                    2 association     -->
   <ATTRIBUTE irq_map> <VALUE array=3D"2">=20
<!--                                  endpoint                 pic obj
line=20
	<VALUE array=3D"3"> <VALUE integer=3D"5"/> <VALUE obj_ref=3D":pic0"/>
<VALUE integer=3D"0"/> </VALUE>
	<VALUE array=3D"3"> <VALUE integer=3D"5"/> <VALUE obj_ref=3D":pic1"/>
<VALUE integer=3D"0"/> </VALUE>
     </VALUE>
   </ATTRIBUTE>
</OBJECT>

>=20
> > I know that this is will result in a large patch set but I think the
> FDT is
> > equally big. Further I believe we can have both schemes in QEMU in
> parallel,
> > if necessary.
>=20
> If the schemes are equivalently powerful, you can have a converter
> which sits outside QEMU.  No need to implement both inside QEMU.
> People do this already, converting config files to QEMU command line
> options.

I see several upsides with the XML parser inside QEMU, but the important
part is that we have a "registry", classes, interfaces and
attributes/properties. I expect that to come with FDT too.

>=20
> Fwiw, Microsoft Virtual PC uses an XML file to describe the machine
> and it makes sense to me.

Very readable. But, I dislike the complex DTD, which needs to be =
maintained
when new machine designs arrive. I believe that Classes and Objects, =
with
relationships, is enough.

Imagine defining a AMP system, not SMP, in VPC. How can we define AMP
machines in FDT? I'm running targets with two CPUs with separate address
spaces and need to do that in the future too.

>=20
> Here's an example from a real VPC machine.  Hmm, maybe it's a bit =
long.
> Is the equivalent FDT any clearer or shorter, though?
>=20
> -- Jamie
>=20
>=20
>=20
> <?xml version=3D"1.0" encoding=3D"UTF-16"?>
> <!-- Microsoft Virtual Machine Options and Settings -->
> <preferences>
>     <version type=3D"string">2.0</version>
>     <alerts>
>         <notifications>
>             <no_boot_disk type=3D"boolean">true</no_boot_disk>
>         </notifications>
>     </alerts>
>     <hardware>
>         <memory>
>             <ram_size type=3D"integer">512</ram_size>
>         </memory>
>         <pci_bus>
>             <ethernet_adapter>
>                 <controller_count =
type=3D"integer">1</controller_count>
>                 <ethernet_controller id=3D"0">
>                     <virtual_network>
>                         <id
> type=3D"bytes">12341234123412341234123412341234</id>
>                         <name type=3D"string">Marvell Yukon 88E8056 =
PCI-E
> Gigabit Ethernet Controller</name>
>                     </virtual_network>
>                     <ethernet_card_address
> type=3D"bytes">000123456789</ethernet_card_address>
>                 </ethernet_controller>
>             </ethernet_adapter>
>             <video_adapter>
>                 <vram_size type=3D"integer">8</vram_size>
>             </video_adapter>
>             <ide_adapter>
>                 <ide_controller id=3D"1">
>                     <location id=3D"0">
>                         <drive_type type=3D"integer">2</drive_type>
>                         <pathname>
>                             <absolute
> type=3D"string">\\srv\Develop\Software\MS SQL =
Eval\SQLEVAL.ISO</absolute>
>                             <relative type=3D"string" />
>                         </pathname>
>                     </location>
>                 </ide_controller>
>                 <ide_controller id=3D"0">
>                     <location id=3D"0">
>                         <drive_type type=3D"integer">1</drive_type>
>                         <pathname>
>                             <absolute type=3D"string">C:\Documents and
> Settings\test\My Documents\My Virtual Machines\test\test Hard
> Disk.vhd</absolute>
>                             <relative type=3D"string">.\test Hard
> Disk.vhd</relative>
>                         </pathname>
>                         <undo_pathname>
>                             <absolute type=3D"string" />
>                             <relative type=3D"string" />
>                         </undo_pathname>
>                     </location>
>                 </ide_controller>
>             </ide_adapter>
>         </pci_bus>
>         <standard>
>             <name type=3D"string">Virtual PC 2007</name>
>             <version type=3D"string">0001.0000.0000</version>
>         </standard>
>         <super_io>
>             <floppy id=3D"0">
>                 <pathname>
>                     <absolute type=3D"string" />
>                     <relative type=3D"string" />
>                 </pathname>
>             </floppy>
>             <floppy>
>                 <auto_detect type=3D"boolean">true</auto_detect>
>             </floppy>
>             <parallel_port>
>                 <port_shared type=3D"boolean">false</port_shared>
>                 <port_type type=3D"integer">0</port_type>
>             </parallel_port>
>             <serial_port>
>                 <connect_immediately
> type=3D"boolean">false</connect_immediately>
>             </serial_port>
>         </super_io>
>         <bios>
>             <base_board>
>                 <serial_number =
type=3D"string">8886-9141-1653-9060-4025-
> 7842-65</serial_number>
>             </base_board>
>             <bios_guid type=3D"string">{125BDA48-420C-446E-AA48-
> 9B597632229C}</bios_guid>
>             <bios_serial_number =
type=3D"string">8886-9141-1653-9060-4025-
> 7842-65</bios_serial_number>
>             <chassis>
>                 <asset_tag =
type=3D"string">8886-9141-1653-9060-4025-7842-
> 65</asset_tag>
>                 <serial_number =
type=3D"string">8886-9141-1653-9060-4025-
> 7842-65</serial_number>
>             </chassis>
>             <cmos
> =
type=3D"bytes">00004000F0223F8002FFFF2F00FF3F1000003F00000000000031004C07=

> =
0707070666FFFF208580FF01000000200C01800CF400000000000000000000000000901
> =
A32E24A580050E999E62401002784004A2080240000000000085AACFE1032547698BAE4
> =
00000000000003000000000000000000000000000000000000000000000000000000000
> =
00000000000000000000000000000000000000000000000000000000000000000000000
> =
00000000000000000000000000000000000000000000000000000000000000000000000
> =
00000000000000000000000000000000000000000000000000000000000000000000000
> </cmos>
>             <time_bytes =
type=3D"bytes">42004800120002290408</time_bytes>
>         </bios>
>     </hardware>
>     <integration>
>         <microsoft>
>             <mouse>
>                 <allow type=3D"boolean">true</allow>
>             </mouse>
>             <video>
>                 <user_selected>
>                     <depth type=3D"integer">16</depth>
>                     <height type=3D"integer">480</height>
>                     <width type=3D"integer">640</width>
>                 </user_selected>
>             </video>
>             <version>
>                 <additions_number
> type=3D"string">013803</additions_number>
>                 <guest_os>
>                     <build_number
> type=3D"string">5.02.3790</build_number>
>                     <long_name type=3D"string">Microsoft Windows =
Server
> 2003</long_name>
>                     <revision_number type=3D"string">Service Pack
> 2</revision_number>
>                     <short_name type=3D"string">Windows Server
> 2003</short_name>
>                     <suite_name type=3D"string">Server</suite_name>
>                 </guest_os>
>             </version>
>         </microsoft>
>     </integration>
>     <properties>
>         <creator>
>             <build type=3D"string">6.0.156.0</build>
>             <name type=3D"string">Microsoft Virtual PC 2007</name>
>         </creator>
>         <modifier>
>             <build type=3D"string">6.0.156.0</build>
>             <name type=3D"string">Microsoft Virtual PC 2007</name>
>         </modifier>
>     </properties>
>     <settings>
>         <shutdown>
>             <prompt type=3D"boolean">true</prompt>
>             <quit>
>                 <action type=3D"integer">4</action>
>                 <was_running type=3D"boolean">false</was_running>
>             </quit>
>             <save>
>                 <enable type=3D"boolean">true</enable>
>             </save>
>             <shutdown>
>                 <enable type=3D"boolean">true</enable>
>             </shutdown>
>             <turn_off>
>                 <enable type=3D"boolean">true</enable>
>             </turn_off>
>             <last_shutdown>
>                 <choice type=3D"integer">0</choice>
>                 <commit type=3D"boolean">true</commit>
>             </last_shutdown>
>         </shutdown>
>         <sound>
>             <sound_adapter>
>                 <enable type=3D"boolean">true</enable>
>             </sound_adapter>
>         </sound>
>         <startup>
>             <automatic>
>                 <type type=3D"integer">2</type>
>             </automatic>
>         </startup>
>         <undo_drives>
>             <enabled type=3D"boolean">false</enabled>
>             <purposely_kept type=3D"boolean">false</purposely_kept>
>             <use_default type=3D"boolean">true</use_default>
>         </undo_drives>
>         <video>
>             <disable_resize type=3D"boolean">false</disable_resize>
>             <full_screen type=3D"boolean">false</full_screen>
>             <mode>
>                 <full_screen>
>                     <startup type=3D"boolean">false</startup>
>                 </full_screen>
>             </mode>
>             <resolutions>
>                 <standard_only type=3D"boolean">false</standard_only>
>             </resolutions>
>             <height type=3D"integer">768</height>
>             <left_position type=3D"integer">1361</left_position>
>             <max_height type=3D"integer">768</max_height>
>             <max_width type=3D"integer">1024</max_width>
>             <top_position type=3D"integer">58</top_position>
>             <width type=3D"integer">1024</width>
>         </video>
>         <guest_os type=3D"integer">6</guest_os>
>     </settings>
>     <virtual_machines>
>         <hw_assist>
>             <enable_hw_assist type=3D"boolean">true</enable_hw_assist>
>         </hw_assist>
>     </virtual_machines>
> </preferences>