From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: "Mahmoud Mandour" <ma.mandourr@gmail.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Alexandre Iooss" <erdnaxe@crans.org>,
"Thomas Huth" <thuth@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Jason Wang" <jasowang@redhat.com>,
"Riku Voipio" <riku.voipio@iki.fi>,
"Laurent Vivier" <laurent@vivier.eu>
Subject: Re: [PATCH 5/7] plugins: fix inclusion of user-mode APIs
Date: Thu, 10 Jul 2025 08:22:33 -0700 [thread overview]
Message-ID: <0052f9d2-53f0-4dab-b594-31f5cf723a64@linaro.org> (raw)
In-Reply-To: <20250710104531.3099313-6-alex.bennee@linaro.org>
On 7/10/25 3:45 AM, Alex Bennée wrote:
> In 903e870f24 (plugins/api: split out binary path/start/end/entry
> code) we didn't actually enable the building of the new plugin helper.
> However this was missed because only contrib plugins like drcov
> actually used the helpers.
>
> With that fixed we discover we also need some more includes to be able
> to extract the relevant data from TaskState.
>
> Fixes: 903e870f24 (plugins/api: split out binary path/start/end/entry code)
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/3014
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> linux-user/plugin-api.c | 1 +
> common-user/plugin-api.c.inc | 1 +
> linux-user/meson.build | 5 ++++-
> 3 files changed, 6 insertions(+), 1 deletion(-)
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
next prev parent reply other threads:[~2025-07-10 15:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-10 10:45 [PATCH 0/7] maintainer updates for 10.1 softfreeeze (gitlab, plugins, docs) pre-PR Alex Bennée
2025-07-10 10:45 ` [PATCH 1/7] gitlab: use argparse in check-units script Alex Bennée
2025-07-10 10:48 ` Manos Pitsidianakis
2025-07-10 10:45 ` [PATCH 2/7] gitlab: add -n option to check_units Alex Bennée
2025-07-10 10:57 ` Manos Pitsidianakis
2025-07-10 10:45 ` [PATCH 3/7] contrib/plugins/execlog: Add tab to the separator search of insn_disas Alex Bennée
2025-07-10 15:22 ` Pierrick Bouvier
2025-07-10 10:45 ` [PATCH 4/7] target/alpha: Add GDB XML feature file Alex Bennée
2025-07-10 10:45 ` [PATCH 5/7] plugins: fix inclusion of user-mode APIs Alex Bennée
2025-07-10 15:22 ` Pierrick Bouvier [this message]
2025-07-10 10:45 ` [PATCH 6/7] docs: use :kbd: role in sphinx docs Alex Bennée
2025-07-10 10:45 ` [PATCH 7/7] docs/system: clean-up formatting of virtio-net-failover Alex Bennée
2025-07-10 10:59 ` Manos Pitsidianakis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0052f9d2-53f0-4dab-b594-31f5cf723a64@linaro.org \
--to=pierrick.bouvier@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=erdnaxe@crans.org \
--cc=jasowang@redhat.com \
--cc=laurent@vivier.eu \
--cc=ma.mandourr@gmail.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=riku.voipio@iki.fi \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).