Re: [Qemu-devel][PATCH] Tap and VLAN socket support for win32

["Kazu" <kazoo@r3.dion.ne.jp>]

[-- Attachment #1: Type: text/plain, Size: 1431 bytes --]

Hi,

I send this mail again because it doesn't reach qemu-devel list by unknown
security reason.

Sent: Sunday, February 05, 2006 3:28 AM Fabrice Bellard wrote:

> Kazu wrote:
>> Thursday, February 02, 2006 8:10 AM Fabrice Bellard wrote:
>>
>>> Hi,
>>>
>>> I merged your patches and I made important changes to simplify them. I
>>> did not do any tests so tell me if you see problems.
>>>
>>
>> -net socket,connect doesn't work. On Windows host, connect returns with
err
>> = WSAEWOULDBLOCK and second time err = WSAEINVAL. I think changing the
>> place
>> of EWOULDBLOCK would be good. On Linux host, EWOULDBLOCK is the same as
>> EAGAIN but a patch works on both Linux and Windows.
>
> Unfortunately on Linux the correct return value we are expecting is
> EINPROGRESS. EAGAIN means that the 'connect' was not initiated so it is
> necessary to redo it.
>

There is not good way to detect a completion of asynchronous connect. So I
used an event object to detect it. A patch is attached.

>>
>> For -net socket,mcast, bind have to be done by sin_addr.s_addr =
>> INADDR_ANY.
>> It seems that it works on Linux host.
>
> It works on Linux but it is not correct because it prevents from
> listening to several multicast addresses at the same time. If doing the
> same on Windows is not possible I agree to make a special case.
>

I couldn't find a way to set a multicast address. I made it a special case
in the patch

Regards,
Kazu

[-- Attachment #2: qemu-20060208-vlan-2.patch.gz --]
[-- Type: application/x-gzip, Size: 1475 bytes --]