From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35809)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <p.fedin@samsung.com>) id 1Zr5au-0005iS-Tv
	for qemu-devel@nongnu.org; Tue, 27 Oct 2015 10:51:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <p.fedin@samsung.com>) id 1Zr5ar-0004f6-ON
	for qemu-devel@nongnu.org; Tue, 27 Oct 2015 10:51:24 -0400
Received: from mailout4.w1.samsung.com ([210.118.77.14]:47119)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <p.fedin@samsung.com>) id 1Zr5ar-0004eq-Jr
	for qemu-devel@nongnu.org; Tue, 27 Oct 2015 10:51:21 -0400
Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244])
	by mailout4.w1.samsung.com
	(Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5
	2014)) with ESMTP id <0NWV0069RVXJLH50@mailout4.w1.samsung.com> for
	qemu-devel@nongnu.org; Tue, 27 Oct 2015 14:51:19 +0000 (GMT)
From: Pavel Fedin <p.fedin@samsung.com>
References: <002701d110be$ed01e4d0$c705ae70$@samsung.com>
	<562F8C40.1030707@redhat.com>
In-reply-to: <562F8C40.1030707@redhat.com>
Date: Tue, 27 Oct 2015 17:51:17 +0300
Message-id: <005401d110c6$efdea550$cf9beff0$@samsung.com>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-transfer-encoding: quoted-printable
Content-language: ru
Subject: Re: [Qemu-devel] [PATCH] backends/hostmem-file: Add file-name
	property
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: 'Eric Blake' <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: 'Paolo Bonzini' <pbonzini@redhat.com>, 'Eduardo Habkost' <ehabkost@redhat.com>

 Hello!

> Is there a missing qapi change, so that the new filename attribute can
> also be specified by QMP command?  Or do we not support hotplug of
> ivshmem yet?

 To tell the truth, i don't know, and we currently do not test ivshmem =
with hotplug here, neither i heard that we would want it. And i actually =
even don't know how hotplug works in qemu.
 I discovered an issue and fixed it - this simple. Without this fix =
ivshmem + hostmem-file is unusable because the file cannot be located, =
therefore the memory cannot be shared.
 Could this (possibly) missing thing be added afterwards, if necessary? =
Anyway, my fix does not break anything (i hope).

Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia