From: Hanna Czenczek <hreitz@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Cc: berrange@redhat.com, afrosi@redhat.com, qemu-devel@nongnu.org
Subject: Re: [PATCH] raw-format: Fix error message for invalid offset/size
Date: Fri, 30 Aug 2024 09:36:42 +0200 [thread overview]
Message-ID: <0061d31c-a8a4-4795-ad44-c32c0dacbfa6@redhat.com> (raw)
In-Reply-To: <20240829185527.47152-1-kwolf@redhat.com>
On 29.08.24 20:55, Kevin Wolf wrote:
> s->offset and s->size are only set at the end of the function and still
> contain the old values when formatting the error message. Print the
> parameters with the new values that we actually checked instead.
>
> Fixes: 500e2434207d ('raw-format: Split raw_read_options()')
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> block/raw-format.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Hanna Czenczek <hreitz@redhat.com>
next prev parent reply other threads:[~2024-08-30 7:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-29 18:55 [PATCH] raw-format: Fix error message for invalid offset/size Kevin Wolf
2024-08-29 21:00 ` Daniel P. Berrangé
2024-08-30 7:36 ` Hanna Czenczek [this message]
2024-10-24 15:23 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0061d31c-a8a4-4795-ad44-c32c0dacbfa6@redhat.com \
--to=hreitz@redhat.com \
--cc=afrosi@redhat.com \
--cc=berrange@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).