From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40844) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YsXA8-0008BS-My for qemu-devel@nongnu.org; Wed, 13 May 2015 09:57:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YsXA4-0004qF-Ik for qemu-devel@nongnu.org; Wed, 13 May 2015 09:57:28 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:12482) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YsXA4-0004mx-D4 for qemu-devel@nongnu.org; Wed, 13 May 2015 09:57:24 -0400 Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NOA003CTK3KID50@mailout4.w1.samsung.com> for qemu-devel@nongnu.org; Wed, 13 May 2015 14:57:20 +0100 (BST) From: Pavel Fedin References: <00c901d08990$2763c410$762b4c30$@samsung.com> <034301d08c92$dccf6e80$966e4b80$@samsung.com> <03e001d08caf$d7fcd1a0$87f674e0$@samsung.com> In-reply-to: Date: Wed, 13 May 2015 16:57:18 +0300 Message-id: <006901d08d84$ba7f0370$2f7d0a50$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7bit Content-language: ru Subject: Re: [Qemu-devel] [PATCH v2] Add virt-v3 machine that uses GIC-500 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: 'Shlomo Pongratz' , qemu-devel@nongnu.org Hello! > 1. In fdt_add_timer why you didn't used the 24 bit limit I posed on the irqflags? Please note that > the argument is 32 bits wide and 8 bits are for flags. Simply missed it when checking for differences. Please fix. :) Perhaps it is the reason why >=24 CPUs fail for you. > 2. In machvirt_init, I used TYPE_AARCH64_CPU while you reverted it to TYPE_ARM_CPU, I > assume this is because you want to support cortex-a15. Don't you think It should be according > to the cortex type? Yes, i just left it as it was because it already works fine with ARM64. Actually, TYPE_AARCH64_CPU is a subclass of TYPE_ARM_CPU. > (BTW you removed cortex-a53). Yes, because i didn't see how it is different from a57 (or a15). I tried to follow minimal intervention principle. But perhaps i was wrong because there was real support for a53 added recently: http://lists.nongnu.org/archive/html/qemu-devel/2015-05/msg01304.html, so feel free to re-add it back. BTW, just for interest, have you tried to do anything with KVM support of vGICv3? I have some code but it's inherently unstable and lock up for unknown (yet) reason. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia