From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EDD7EC433F5 for ; Mon, 28 Feb 2022 16:23:40 +0000 (UTC) Received: from localhost ([::1]:56590 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nOioF-0008PB-OK for qemu-devel@archiver.kernel.org; Mon, 28 Feb 2022 11:23:39 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49732) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nOimk-00075e-9t; Mon, 28 Feb 2022 11:22:06 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:52972 helo=outgoing.mit.edu) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nOimi-0006Ap-KH; Mon, 28 Feb 2022 11:22:05 -0500 Received: from [10.31.51.144] (dhcp-10-31-51-144.dyn.MIT.EDU [10.31.51.144]) (authenticated bits=0) (User authenticated as schaub@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 21SGM1tL003469 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NOT); Mon, 28 Feb 2022 11:22:02 -0500 Message-ID: <006d618a-07d5-f58c-fdce-18914c7c7625@mit.edu> Date: Mon, 28 Feb 2022 11:22:08 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH] allow disabling tests Content-Language: en-US To: Peter Maydell References: From: Simeon Schaub In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=18.9.28.11; envelope-from=schaub@mit.edu; helo=outgoing.mit.edu X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Ah, yes, sorry, I didn't check whether the tests were actually run. I can rename this to something more like `build-tests` if you think that's more informative. Best, Simeon On 2/28/22 11:16, Peter Maydell wrote: > On Mon, 28 Feb 2022 at 16:10, Simeon Schaub wrote: >> >> From b6ec17a85a8fb2431545f9c5093dbce9a090b522 Mon Sep 17 00:00:00 2001 >> From: Simeon David Schaub >> Date: Mon, 28 Feb 2022 10:51:04 -0500 >> Subject: [PATCH] allow disabling tests >> >> Adds an option to avoid running tests as part of the build process. I >> ran `make update-buildoptions` to update the meson options, but this >> seemed to also change the `qga-vss` option. I assume this isn't intended >> to happen, any ideas what's going on there? > > What tests are we running as part of the build process? > I wouldn't expect us to run any tests unless you ask for them > by running "make check". > > We *build* the testcase binaries as part of the build process, which > perhaps is what you're running into ? > > thanks > -- PMM