From: Thomas Huth <thuth@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: f4bug@amsat.org, eblake@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 22/23] libqtest: Replace qtest_startf() by qtest_initf()
Date: Fri, 27 Jul 2018 19:18:08 +0200 [thread overview]
Message-ID: <007a70a2-4ee1-5d41-e53e-35d92f53f518@redhat.com> (raw)
In-Reply-To: <20180727151359.29061-23-armbru@redhat.com>
On 07/27/2018 05:13 PM, Markus Armbruster wrote:
> qtest_init() creates a new QTestState, and leaves @global_qtest alone.
> qtest_start() additionally assigns it to @global_qtest, but
> qtest_startf() additionall sets assigns NULL to @global_qtest. This
> makes no sense. Replace it by qtest_initf() that works like
> qtest_init(), i.e. leaves @global_qtest alone.
FWIW, the original idea was to get rid of global_qtest, and then to
remove qtest_init instead:
https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg02723.html
Not sure whether Eric is still working on these patches, though.
Thomas
next prev parent reply other threads:[~2018-07-27 17:18 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-27 15:13 [Qemu-devel] [PATCH v2 00/23] tests: Compile-time format string checking for libqtest.h Markus Armbruster
2018-07-27 15:13 ` [Qemu-devel] [PATCH v2 01/23] libqtest: Document calling conventions Markus Armbruster
2018-07-27 15:13 ` [Qemu-devel] [PATCH v2 02/23] libqtest: Rename functions to send QMP messages Markus Armbruster
2018-07-27 15:24 ` Eric Blake
2018-07-30 5:41 ` Markus Armbruster
2018-07-27 16:35 ` Thomas Huth
2018-07-27 17:06 ` Eric Blake
2018-07-27 15:13 ` [Qemu-devel] [PATCH v2 03/23] libqtest: Clean up how we read device_del messages Markus Armbruster
2018-07-27 15:24 ` Eric Blake
2018-07-27 15:13 ` [Qemu-devel] [PATCH v2 04/23] libqtest: Clean up how we read the QMP greeting Markus Armbruster
2018-07-27 15:25 ` Eric Blake
2018-07-27 15:13 ` [Qemu-devel] [PATCH v2 05/23] qobject: Replace qobject_from_jsonf() by qobject_from_jsonf_nofail() Markus Armbruster
2018-07-27 15:28 ` Eric Blake
2018-07-27 15:13 ` [Qemu-devel] [PATCH v2 06/23] qobject: New qobject_from_vjsonf_nofail(), qdict_from_vjsonf_nofail() Markus Armbruster
2018-07-27 15:30 ` Eric Blake
2018-07-27 15:13 ` [Qemu-devel] [PATCH v2 07/23] libqtest: Simplify qmp_fd_vsend() a bit Markus Armbruster
2018-07-27 15:31 ` Eric Blake
2018-07-27 15:13 ` [Qemu-devel] [PATCH v2 08/23] test-qobject-input-visitor: Avoid format string ambiguity Markus Armbruster
2018-07-27 15:33 ` Eric Blake
2018-07-27 15:13 ` [Qemu-devel] [PATCH v2 09/23] qobject: qobject_from_jsonv() is dangerous, hide it away Markus Armbruster
2018-07-27 15:34 ` Eric Blake
2018-07-27 15:13 ` [Qemu-devel] [PATCH v2 10/23] tests: Pass literal format strings directly to qmp_FOO() Markus Armbruster
2018-07-27 15:35 ` Eric Blake
2018-07-27 15:13 ` [Qemu-devel] [PATCH v2 11/23] tests: Clean up string interpolation into QMP input (simple cases) Markus Armbruster
2018-07-27 15:39 ` Eric Blake
2018-07-27 15:13 ` [Qemu-devel] [PATCH v2 12/23] cpu-plug-test: Don't pass integers as strings to device_add Markus Armbruster
2018-07-27 15:42 ` Eric Blake
2018-07-27 15:13 ` [Qemu-devel] [PATCH v2 13/23] tests: Clean up string interpolation around qtest_qmp_device_add() Markus Armbruster
2018-07-27 15:48 ` Eric Blake
2018-07-30 6:04 ` Markus Armbruster
2018-07-30 8:34 ` Markus Armbruster
2018-07-30 15:25 ` Eric Blake
2018-07-31 6:16 ` Markus Armbruster
2018-07-27 15:13 ` [Qemu-devel] [PATCH v2 14/23] migration-test: Make wait_command() return the "return" member Markus Armbruster
2018-07-27 15:50 ` Eric Blake
2018-07-27 15:13 ` [Qemu-devel] [PATCH v2 15/23] tests: New helper qtest_qmp_receive_success() Markus Armbruster
2018-07-27 16:00 ` Eric Blake
2018-07-30 6:10 ` Markus Armbruster
2018-07-27 15:13 ` [Qemu-devel] [PATCH v2 16/23] migration-test: Make wait_command() cope with '%' Markus Armbruster
2018-07-27 16:02 ` Eric Blake
2018-07-27 15:13 ` [Qemu-devel] [PATCH v2 17/23] migration-test: Clean up string interpolation into QMP, part 1 Markus Armbruster
2018-07-27 16:04 ` Eric Blake
2018-07-27 15:13 ` [Qemu-devel] [PATCH v2 18/23] migration-test: Clean up string interpolation into QMP, part 2 Markus Armbruster
2018-07-27 16:05 ` Eric Blake
2018-07-30 6:19 ` Markus Armbruster
2018-07-27 15:13 ` [Qemu-devel] [PATCH v2 19/23] migration-test: Clean up string interpolation into QMP, part 3 Markus Armbruster
2018-07-27 16:11 ` Eric Blake
2018-07-30 6:25 ` Markus Armbruster
2018-07-27 15:13 ` [Qemu-devel] [PATCH v2 20/23] libqtest: Enable compile-time format string checking Markus Armbruster
2018-07-27 16:18 ` Eric Blake
2018-07-27 15:13 ` [Qemu-devel] [PATCH v2 21/23] libqtest: Remove qtest_qmp_discard_response() & friends Markus Armbruster
2018-07-27 16:46 ` Thomas Huth
2018-07-27 17:03 ` Eric Blake
2018-07-30 6:32 ` Markus Armbruster
2018-08-01 6:46 ` Thomas Huth
2018-08-02 4:53 ` Markus Armbruster
2018-08-02 5:30 ` Thomas Huth
2018-08-02 18:31 ` Markus Armbruster
2018-07-27 17:05 ` Eric Blake
2018-07-30 6:28 ` Markus Armbruster
2018-07-27 15:13 ` [Qemu-devel] [PATCH v2 22/23] libqtest: Replace qtest_startf() by qtest_initf() Markus Armbruster
2018-07-27 17:08 ` Eric Blake
2018-07-30 6:32 ` Markus Armbruster
2018-07-27 17:18 ` Thomas Huth [this message]
2018-07-27 18:52 ` Eric Blake
2018-07-27 15:13 ` [Qemu-devel] [PATCH v2 23/23] libqtest: Rename qtest_FOOv() to qtest_vFOO() for consistency Markus Armbruster
2018-07-27 17:10 ` Eric Blake
2018-07-27 17:19 ` Thomas Huth
2018-07-30 6:47 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=007a70a2-4ee1-5d41-e53e-35d92f53f518@redhat.com \
--to=thuth@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).