From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 864B6C43461 for ; Thu, 17 Sep 2020 08:20:41 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1BB1A206DB for ; Thu, 17 Sep 2020 08:20:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Q4g0x1/I" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1BB1A206DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53434 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kIp9h-0000N0-Bb for qemu-devel@archiver.kernel.org; Thu, 17 Sep 2020 04:20:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52912) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIonW-0004KX-QP; Thu, 17 Sep 2020 03:57:46 -0400 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]:40834) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kIonT-0005wf-MM; Thu, 17 Sep 2020 03:57:42 -0400 Received: by mail-wm1-x335.google.com with SMTP id k18so1019858wmj.5; Thu, 17 Sep 2020 00:57:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-transfer-encoding:content-language :thread-index; bh=0dCsAB7sgvO3ijWAYy2/up8BNNwtjUjyvJiAJ0hrsQw=; b=Q4g0x1/IsGREWR0kbKpY2l8DwkxU+dS4gTBbw0CpOlamuknmRuFWE9lVdDWmsCGsHY JjPlYSAGVJJxZ/ug9VaBt/H4WqVmuid2Bd6fGItVIfgk/OkTjFvymQAns7fsIwqubg18 7V+K4H4Nskpy1G7d9nzhV0yu9mopqqOcaddrtsllP3Hq2SBL3XQzTS8QgX5YhDLUMtu8 SSEcignZB2aUctHKk21XskeVp/fFvCN3SU75mo/BaupV11nzsqipxZoprq3y/bFlmTEa wJtpEELAZLJWuJ072ECkX6OufwippgFlr3ichq1Ni/2+cT1/wox16G8yHIF0LvBXuv39 jxSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:to:cc:references:in-reply-to :subject:date:message-id:mime-version:content-transfer-encoding :content-language:thread-index; bh=0dCsAB7sgvO3ijWAYy2/up8BNNwtjUjyvJiAJ0hrsQw=; b=SkPPWuzsK5Oa4WvcocE3MkJ8/rg/r2ZtqpCGJZ9kFdyOHTZD0fQKpcwZ9MtO8tXsKv y7pbHLnynAJVhTjpiO+yPqfzs9rg6FFf76XexZSqs3vLkg+YnFqVoPe/ujanYw9G6FJ+ ljudmvy9qsxzfj2AHRT9RI7RWchvp0ejwGC3jXqbiLmqZnUG8I2MI6bnd7ysMZkwHbgh QgAChyihOgQhXmhgxmbd6nzGRHW9OGSmQbAvfnqKjzzOm9M8i6vx2P0fFv2l1Nz/a+3N 4lc7Qtbx2v4CYjRArsfEZfRgers3mAA5FWs5u6QJae5sPquIAJH5g6Fmsgyd1JmivIS1 ZlXA== X-Gm-Message-State: AOAM530g/IJ3OdOoqBreqU/NVe/dd5mg/5Ai17DFhxy4oOFvzUIHwKxQ px5ATqHxaOGEj+dQZ5lBqWc= X-Google-Smtp-Source: ABdhPJwEFP1IvlYvUVQzkk2Mche6UC+K5+G3jqaxP/E6EJ12vTu81AGm1S9kC3+lb5YcGOXL+ZDd4g== X-Received: by 2002:a1c:7d55:: with SMTP id y82mr8635606wmc.100.1600329456159; Thu, 17 Sep 2020 00:57:36 -0700 (PDT) Received: from CBGR90WXYV0 (host86-176-94-160.range86-176.btcentralplus.com. [86.176.94.160]) by smtp.gmail.com with ESMTPSA id g14sm9401272wrv.25.2020.09.17.00.57.34 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 17 Sep 2020 00:57:35 -0700 (PDT) From: Paul Durrant X-Google-Original-From: "Paul Durrant" To: "'Eduardo Habkost'" , References: <20200916182519.415636-1-ehabkost@redhat.com> <20200916182519.415636-4-ehabkost@redhat.com> In-Reply-To: <20200916182519.415636-4-ehabkost@redhat.com> Subject: RE: [PATCH 3/5] qom: Remove module_obj_name parameter from OBJECT_DECLARE* macros Date: Thu, 17 Sep 2020 08:57:33 +0100 Message-ID: <007c01d68cc8$347614f0$9d623ed0$@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Content-Language: en-gb Thread-Index: AQIelPz0+HUIa2jn7mxP/pozU40YBAMHPXtoqMQrdLA= Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=xadimgnik@gmail.com; helo=mail-wm1-x335.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: paul@xen.org Cc: 'Fam Zheng' , 'Peter Maydell' , 'Sarah Harris' , 'Chris Wulff' , 'Sagar Karandikar' , "'Michael S. Tsirkin'" , 'Anthony Green' , 'Mark Cave-Ayland' , 'Aleksandar Rikalo' , 'Jiaxun Yang' , 'Max Filippov' , 'Gerd Hoffmann' , "'Edgar E. Iglesias'" , 'Guan Xuetao' , 'Marek Vasut' , 'Stefano Stabellini' , xen-devel@lists.xenproject.org, 'Yoshinori Sato' , 'David Hildenbrand' , 'Halil Pasic' , 'Christian Borntraeger' , 'Aleksandar Markovic' , "'Gonglei \(Arei\)'" , 'Anthony Perard' , =?utf-8?Q?'Marc-Andr=C3=A9_Lureau'?= , 'Richard Henderson' , 'Artyom Tarasenko' , 'Laurent Vivier' , 'Thomas Huth' , 'Amit Shah' , 'Alistair Francis' , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, 'Michael Rolnik' , =?utf-8?Q?'C=C3=A9dric_Le_Goater'?= , 'Igor Mammedov' , qemu-ppc@nongnu.org, 'Stafford Horne' , 'Palmer Dabbelt' , 'David Gibson' , "'Daniel P. Berrange'" , qemu-block@nongnu.org, qemu-riscv@nongnu.org, 'Bastian Koppelmann' , 'Cornelia Huck' , =?utf-8?Q?'Philippe_Mathieu-Daud=C3=A9'?= , 'Michael Walle' , 'Corey Minyard' , 'Paolo Bonzini' , 'Aurelien Jarno' , 'Stefan Berger' Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" > -----Original Message----- > From: Eduardo Habkost > Sent: 16 September 2020 19:25 > To: qemu-devel@nongnu.org > Cc: Paolo Bonzini ; Daniel P. Berrange = ; Marc-Andr=C3=A9 Lureau > ; Gerd Hoffmann ; = Michael S. Tsirkin ; > Peter Maydell ; Corey Minyard = ; C=C3=A9dric Le Goater > ; David Gibson ; Cornelia = Huck ; Thomas > Huth ; Halil Pasic ; Christian = Borntraeger > ; Philippe Mathieu-Daud=C3=A9 = ; Alistair Francis > ; David Hildenbrand ; = Laurent Vivier ; > Amit Shah ; Stefano Stabellini = ; Anthony Perard > ; Paul Durrant ; Fam Zheng = ; Gonglei (Arei) > ; Igor Mammedov ; Stefan = Berger ; > Richard Henderson ; Michael Rolnik = ; Sarah Harris > ; Edgar E. Iglesias ; = Michael Walle > ; Aleksandar Markovic = ; Aurelien Jarno > ; Jiaxun Yang ; = Aleksandar Rikalo > ; Anthony Green ; = Chris Wulff ; > Marek Vasut ; Stafford Horne ; Palmer = Dabbelt ; > Sagar Karandikar ; Bastian Koppelmann = ; > Yoshinori Sato ; Mark Cave-Ayland = ; Artyom > Tarasenko ; Guan Xuetao ; = Max Filippov ; > qemu-arm@nongnu.org; qemu-ppc@nongnu.org; qemu-s390x@nongnu.org; = qemu-block@nongnu.org; xen- > devel@lists.xenproject.org; qemu-riscv@nongnu.org > Subject: [PATCH 3/5] qom: Remove module_obj_name parameter from = OBJECT_DECLARE* macros >=20 > One of the goals of having less boilerplate on QOM declarations > is to avoid human error. Requiring an extra argument that is > never used is an opportunity for mistakes. >=20 > Remove the unused argument from OBJECT_DECLARE_TYPE and > OBJECT_DECLARE_SIMPLE_TYPE. >=20 > Coccinelle patch used to convert all users of the macros: >=20 > @@ > declarer name OBJECT_DECLARE_TYPE; > identifier InstanceType, ClassType, lowercase, UPPERCASE; > @@ > OBJECT_DECLARE_TYPE(InstanceType, ClassType, > - lowercase, > UPPERCASE); >=20 > @@ > declarer name OBJECT_DECLARE_SIMPLE_TYPE; > identifier InstanceType, lowercase, UPPERCASE; > @@ > OBJECT_DECLARE_SIMPLE_TYPE(InstanceType, > - lowercase, > UPPERCASE); >=20 > Signed-off-by: Eduardo Habkost Acked-by: Paul Durrant