From: "Tobias Fiebig" <tobias@fiebig.nl>
To: "'Jason Wang'" <jasowang@redhat.com>
Cc: "'Stefan Hajnoczi'" <stefanha@redhat.com>,
<qemu-devel@nongnu.org>, <qemu-stable@nongnu.org>,
"'Russell King - ARM Linux'" <linux@armlinux.org.uk>
Subject: RE: [PATCH for-7.2] rtl8139: honor large send MSS value
Date: Wed, 16 Nov 2022 12:20:23 +0100 [thread overview]
Message-ID: <008c01d8f9ad$6ba58e20$42f0aa60$@fiebig.nl> (raw)
In-Reply-To:
Heho,
Quick follow-up; Applied the change you suggested, but there are still some things to test.
While this now works (mostly), MSS values are still off; Especially the behavior below <=1036 is difficult, as for v4 the minimum MTU is 576 and minimum MSS is 536:
Requested DPRINT
1320 1292
1319 1291
1100 1024
1036 1024
1035 271
1000 268
So, I guess there is something else amiss; Will test more in-depth later tonight and shift the bits a bit; Also, I will look into behavior when forcing >1500 MTUs (in case that works with the rtl8139).
Sidenote: This all seems to be a non-issue for v6, as the RTL8139 does not support TSO for v6, so at least one thing less to worry about. ;-)
With best regards,
Tobias
next prev parent reply other threads:[~2022-11-16 11:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 16:36 [PATCH for-7.2] rtl8139: honor large send MSS value Stefan Hajnoczi
2022-11-15 23:36 ` Tobias Fiebig
2022-11-16 4:19 ` Jason Wang
2022-11-16 2:58 ` Tobias Fiebig
2022-11-16 6:54 ` Jason Wang
2022-11-16 10:04 ` Tobias Fiebig
2022-11-16 11:20 ` Tobias Fiebig [this message]
2022-11-16 15:47 ` Stefan Hajnoczi
2022-11-17 2:49 ` Tobias Fiebig
2022-11-17 11:07 ` Stefan Hajnoczi
2022-11-17 11:15 ` Stefan Hajnoczi
2022-11-17 11:26 ` Tobias Fiebig
2022-11-17 16:56 ` Stefan Hajnoczi
2022-11-17 17:02 ` Tobias Fiebig
2022-11-17 20:42 ` Tobias Fiebig
2022-11-17 22:51 ` Stefan Hajnoczi
2022-11-18 7:10 ` Jason Wang
2022-11-16 4:13 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='008c01d8f9ad$6ba58e20$42f0aa60$@fiebig.nl' \
--to=tobias@fiebig.nl \
--cc=jasowang@redhat.com \
--cc=linux@armlinux.org.uk \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).