From: Thomas Huth <thuth@redhat.com>
To: Daniel Henrique Barboza <danielhb413@gmail.com>, qemu-devel@nongnu.org
Cc: Halil Pasic <pasic@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Cornelia Huck <cohuck@redhat.com>
Subject: Re: [PATCH v2 1/1] s390x/event-facility.c: remove unneeded labels
Date: Mon, 13 Jan 2020 17:02:22 +0100 [thread overview]
Message-ID: <00966969-db8b-3b1a-3584-d581bd8ef91c@redhat.com> (raw)
In-Reply-To: <20200108144607.878862-1-danielhb413@gmail.com>
On 08/01/2020 15.46, Daniel Henrique Barboza wrote:
> 'out' label from write_event_mask() and and write_event_data()
> can be replaced by 'return'.
>
> The 'out' label from read_event_data() can also be replaced.
> However, as suggested by Cornelia Huck, instead of simply
> replacing the 'out' label, let's also change the code flow
> a bit to make it clearer that sccb events are always handled
> regardless of the mask for unconditional reads, while selective
> reads are handled if the mask is valid.
>
> CC: Cornelia Huck <cohuck@redhat.com>
> CC: Thomas Huth <thuth@redhat.com>
> CC: Halil Pasic <pasic@linux.ibm.com>
> CC: Christian Borntraeger <borntraeger@de.ibm.com>
> Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Wow, that cleans up quite a bit of goto-spaghetti-code!
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2020-01-13 16:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 14:46 [PATCH v2 1/1] s390x/event-facility.c: remove unneeded labels Daniel Henrique Barboza
2020-01-13 16:02 ` Thomas Huth [this message]
2020-01-13 16:52 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00966969-db8b-3b1a-3584-d581bd8ef91c@redhat.com \
--to=thuth@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=danielhb413@gmail.com \
--cc=pasic@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).