From: Eric Blake <eblake@redhat.com>
To: Sameeh Jubran <sameeh@daynix.com>,
qemu-devel@nongnu.org, Jason Wang <jasowang@redhat.com>
Cc: Yan Vugenfirer <yan@daynix.com>
Subject: Re: [Qemu-devel] [RFC 2/6] tap: Add support for bpf ioctls
Date: Thu, 30 Aug 2018 10:21:14 -0500 [thread overview]
Message-ID: <009b673f-7872-af95-77a7-2bc7de4658e6@redhat.com> (raw)
In-Reply-To: <20180830142708.14311-3-sameeh@daynix.com>
On 08/30/2018 09:27 AM, Sameeh Jubran wrote:
> From: Sameeh Jubran <sjubran@redhat.com>
>
> Starting from kernel v4.16 tun device supports TUNSETSTEERINGEBPF and
> TUNSETFILTEREBPF.
>
> Signed-off-by: Sameeh Jubran <sjubran@redhat.com>
> ---
> +++ b/qapi/net.json
> @@ -692,3 +692,14 @@
> ##
> { 'event': 'NIC_RX_FILTER_CHANGED',
> 'data': { '*name': 'str', 'path': 'str' } }
> +
> +##
> +# @BPFType:
> +#
> +# BPF programs types provided as an argument for tap bpf ioctls
> +#
> +# Since: 2.12
You missed 2.12 by a long shot; this should be 3.1.
> +#
> +##
> +{ 'enum': 'BPFType',
> + 'data': [ 'filter', 'steering' ] }
It might also be wise to document these two values in addition to the
documentation of the enum as a whole.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2018-08-30 15:21 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-30 14:27 [Qemu-devel] [RFC 0/6] Virtio-net: Support RSS Sameeh Jubran
2018-08-30 14:27 ` [Qemu-devel] [RFC 1/6] Add bpf support to qemu Sameeh Jubran
2018-09-03 11:59 ` Daniel P. Berrangé
2018-09-03 12:18 ` Sameeh Jubran
2018-09-03 12:24 ` Peter Maydell
2018-09-03 12:28 ` Sameeh Jubran
2018-09-03 12:29 ` Daniel P. Berrangé
2018-08-30 14:27 ` [Qemu-devel] [RFC 2/6] tap: Add support for bpf ioctls Sameeh Jubran
2018-08-30 15:21 ` Eric Blake [this message]
2018-09-03 11:34 ` Sameeh Jubran
2018-09-03 3:24 ` Jason Wang
2018-09-03 11:33 ` Sameeh Jubran
2018-08-30 14:27 ` [Qemu-devel] [RFC 3/6] vhost-net: Expose vhost_net_get_fd Sameeh Jubran
2018-09-03 3:24 ` Jason Wang
2018-09-03 11:56 ` Sameeh Jubran
2018-08-30 14:27 ` [Qemu-devel] [RFC 4/6] virtio-net: implement steering mode feature Sameeh Jubran
2018-09-03 3:34 ` Jason Wang
2018-09-03 12:51 ` Sameeh Jubran
2018-08-30 14:27 ` [Qemu-devel] [RFC 5/6] virtio-net: steering mode: Implement rss support Sameeh Jubran
2018-09-03 3:48 ` Jason Wang
2018-09-03 11:45 ` Sameeh Jubran
2018-08-30 14:27 ` [Qemu-devel] [RFC 6/6] virtio-net: rss: Add bpf filter Sameeh Jubran
2018-09-03 4:12 ` Jason Wang
2018-09-03 13:16 ` Sameeh Jubran
2018-09-04 3:03 ` Jason Wang
2018-09-03 11:54 ` Daniel P. Berrangé
2018-09-03 12:35 ` Sameeh Jubran
2018-09-03 12:49 ` Daniel P. Berrangé
2018-09-04 3:07 ` Jason Wang
2018-09-04 8:14 ` Daniel P. Berrangé
2018-09-06 5:26 ` Jason Wang
2018-10-04 13:30 ` Daniel P. Berrangé
2018-09-03 12:11 ` Daniel P. Berrangé
2018-09-04 20:11 ` Eric Blake
2018-09-03 4:15 ` [Qemu-devel] [RFC 0/6] Virtio-net: Support RSS Jason Wang
2018-09-03 9:52 ` Sameeh Jubran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=009b673f-7872-af95-77a7-2bc7de4658e6@redhat.com \
--to=eblake@redhat.com \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sameeh@daynix.com \
--cc=yan@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).