From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE5EDC433DB for ; Tue, 2 Mar 2021 19:21:52 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EB9C6614A7 for ; Tue, 2 Mar 2021 19:21:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EB9C6614A7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47868 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHAac-000138-Qj for qemu-devel@archiver.kernel.org; Tue, 02 Mar 2021 14:21:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45438) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHA5i-0000AR-TW for qemu-devel@nongnu.org; Tue, 02 Mar 2021 13:49:54 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:56606) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lHA5g-0006j4-Qh for qemu-devel@nongnu.org; Tue, 02 Mar 2021 13:49:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614710991; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IR1YAVeJ202fVrs/8ViqUhFw7rZvCOQ+z8TsDd76k1g=; b=Kc/2Zn4Dah2KGHEdcPE+lyL1+skatziQMpnRv0yRYUfSc/Aw3Bb95Kt5kuGNdKL+bX+noQ k/x3zYmMzw021NxWdvAv/7Zig9VHzY1pcpSGnVH7Q0jWdpMxC6ftHExWJoJjwYVCCWKYtI 0a0N12g7NDtUJA8LpFRs82IYXPQyhFc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-162-pxWDeOI1Poej7F2iQZNPaQ-1; Tue, 02 Mar 2021 13:49:50 -0500 X-MC-Unique: pxWDeOI1Poej7F2iQZNPaQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8427B107ACC7 for ; Tue, 2 Mar 2021 18:49:49 +0000 (UTC) Received: from thuth.remote.csb (ovpn-112-57.ams2.redhat.com [10.36.112.57]) by smtp.corp.redhat.com (Postfix) with ESMTP id B0B566026B; Tue, 2 Mar 2021 18:49:48 +0000 (UTC) Subject: Re: [PATCH v3] vl: deprecate -writeconfig To: Paolo Bonzini , qemu-devel@nongnu.org References: <20210302180023.54555-1-pbonzini@redhat.com> From: Thomas Huth Message-ID: <00b49052-0338-8753-114f-a8eca9bbb11f@redhat.com> Date: Tue, 2 Mar 2021 19:49:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210302180023.54555-1-pbonzini@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: armbru@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 02/03/2021 19.00, Paolo Bonzini wrote: > The functionality of -writeconfig is limited and the code > does not even try to detect cases where it prints incorrect > syntax (for example if values have a quote in them, since > qemu_config_parse does not support any kind of escaping) > so remove it. > > Signed-off-by: Paolo Bonzini > --- > docs/system/deprecated.rst | 7 +++++++ > qemu-options.hx | 7 +------ > softmmu/vl.c | 1 + > 3 files changed, 9 insertions(+), 6 deletions(-) > > diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst > index 2fcac7861e..561c916da2 100644 > --- a/docs/system/deprecated.rst > +++ b/docs/system/deprecated.rst > @@ -146,6 +146,13 @@ library enabled as a cryptography provider. > Neither the ``nettle`` library, or the built-in cryptography provider are > supported on FIPS enabled hosts. > > +``-writeconfig`` (since 6.0) > +''''''''''''''''''''''''''''' > + > +The ``-writeconfig`` option is not able to serialize the entire contents > +of the QEMU command line. It is thus considered a failed experiment > +and deprecated, with no current replacement. > + > QEMU Machine Protocol (QMP) commands > ------------------------------------ > > diff --git a/qemu-options.hx b/qemu-options.hx > index 34be5a7a2d..252db9357c 100644 > --- a/qemu-options.hx > +++ b/qemu-options.hx > @@ -4335,13 +4335,8 @@ SRST > ERST > DEF("writeconfig", HAS_ARG, QEMU_OPTION_writeconfig, > "-writeconfig \n" > - " read/write config file\n", QEMU_ARCH_ALL) > + " read/write config file (deprecated)\n", QEMU_ARCH_ALL) > SRST > -``-writeconfig file`` > - Write device configuration to file. The file can be either filename > - to save command line and device configuration into file or dash > - ``-``) character to print the output to stdout. This can be later > - used as input file for ``-readconfig`` option. > ERST > > DEF("no-user-config", 0, QEMU_OPTION_nouserconfig, > diff --git a/softmmu/vl.c b/softmmu/vl.c > index b219ce1f35..10bd8a10a3 100644 > --- a/softmmu/vl.c > +++ b/softmmu/vl.c > @@ -3356,6 +3356,7 @@ void qemu_init(int argc, char **argv, char **envp) > case QEMU_OPTION_writeconfig: > { > FILE *fp; > + warn_report("-writeconfig is deprecated and will go away without a replacement"); > if (strcmp(optarg, "-") == 0) { > fp = stdout; > } else { > Reviewed-by: Thomas Huth