From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 74D21C87FD2 for ; Mon, 11 Aug 2025 13:47:24 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ulSqy-0006Y5-2y; Mon, 11 Aug 2025 09:46:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ulSqq-0006UK-0I for qemu-devel@nongnu.org; Mon, 11 Aug 2025 09:46:12 -0400 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ulSqg-0007tx-ET for qemu-devel@nongnu.org; Mon, 11 Aug 2025 09:46:11 -0400 Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-3b79bd3b1f7so2018179f8f.1 for ; Mon, 11 Aug 2025 06:45:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1754919935; x=1755524735; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=GLdxbB8HAuK7i3SENIBtqw2FAOPAXoomdFfPQKwjvn0=; b=JG6QjYH8EH2iC8MOkrizJrqugeY2ss/KpTnIb9K1+G2N7qk0JdaVe/pxZOEAe69VoB Hxh8zQhDzQaykboX1pw+6cRty1sAjaUD+lYpZvp4E1Zn+tkQPr6qYn4kQiFgwhfAq4le ce8hy563FmgR7W19PznZwIIcrOEfQLuxQMImF1S2th29kq+oMWTAISlqKP3pK27jxNdN jvhlc7lQ2w9tAM5ddcgVol7DfrVkrcWZ3nyToxFkAadJaq5lmSivLMFm8zv6dTerVe3a Jgw1Ifffa+ulWlG23i+L6GCOwzyNGCJDJS5mRILsuKVVL/2qekc7arl5oJDB86IJsUnL AuyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754919935; x=1755524735; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GLdxbB8HAuK7i3SENIBtqw2FAOPAXoomdFfPQKwjvn0=; b=dyTkvxYEQi85P0jkwcB3VjR68Jzc4co6zPQv3lB3wwGkR1d5Lrk9lY2glJayRLID2G Z6HE018xhP5RrI9D8IBa98wJGkwub2fCts112dFGvuFSWa1atcRO2YcJMmloskAfEplb Htm8c3ajn/ZqD88XcrfJE1B2p4ZjZRzTEXhg9oaKRDMEmHWXg9O/s36txwBxSitEYllc xRMH8uqKiKYDSvoUw9w3NN5TNy70WmtqHSATG91xdQ/lMQqvddjN3fv7cDmds3d7mE5N g78bbPnbluSDyk10MrPDTGoz3T1eMeAcTm+aGanMmRSzOZEhPIagvpYFoVD4jx5SoaUg 1THQ== X-Forwarded-Encrypted: i=1; AJvYcCV1egCdDcmu1uUzKQk4fFpo3lbW5d8cA3JT9pIpsMKPaBabcnBVKxYb5xW6xHR4w0CvnMt/+co4EaR0@nongnu.org X-Gm-Message-State: AOJu0YxILmmxNFrJxTaCW2tvK8FXs24/sdzP0Xp6oqU2tc5bdpZoHqL0 yVXaROByMbaOVxul8J0h2Xi96pTCiwBl9K9b1PRyPgi9qTZxOT9zcf1rmNurMSzCVQ8= X-Gm-Gg: ASbGnctRsJSelJcalrCQ5BRUy7Qc7wHl2c0VHwNJQRubxSzRQPE/AZHJpkkKkK8Gw5S NjFj1dHAAxRn5/rCV25NzGWcw9irSXkNvyHI0/W6o3S57kThqkk5bY5KjTg5zx+mUKvq2EwTftG rLhO7uPFZ0NM+HquxdqtbrX1Be0Kc2hjeyOPtm6prc4deTPPCAzAPKAIE05XxqOMxWXZ3GfSrkk oPh9TUG+mMZhSc28E0h+PxK95ukAxXULA5kOTq6bF6MFwd/HqfqHrb/mSmwFURmA2Xz95st+a6c 8WkYes87UKM6AdAMOgyotS7r9bsR6YUjxYam6GKViip9YMifHIF1sBcRjE7OsJtq2BMLkWGLlNe SSH9C9LyIJ9FiPjHpW+6+ANk0qHYcnvtlVF/OofEbNlYNfNE6y8dEemg5VPoEPH88NMghDw8= X-Google-Smtp-Source: AGHT+IGFkOpfg2DIAbLUDdSR9qfzHR7j6sPRpGJvNy97Y7yU4pyYZ7ym0/Qd3WDEhl+lVOB9y0W3tw== X-Received: by 2002:a05:6000:26ca:b0:3b7:97c8:daad with SMTP id ffacd0b85a97d-3b900b6ac1cmr9765008f8f.55.1754919935298; Mon, 11 Aug 2025 06:45:35 -0700 (PDT) Received: from [192.168.69.210] (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b79c466838sm42932683f8f.49.2025.08.11.06.45.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Aug 2025 06:45:34 -0700 (PDT) Message-ID: <00bb0213-e4b3-457b-b5df-f575865b91ff@linaro.org> Date: Mon, 11 Aug 2025 15:45:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/1] target/arm: Trap PMCR when MDCR_EL2.TPMCR is set To: Smail AIDER , "qemu-devel@nongnu.org" Cc: Alexander Spyridakis , "zhangyue (BA)" , "Liuyutao(DRC)" , "mjt@tls.msk.ru" , Peter Maydell , "qemu-arm@nongnu.org" , "richard.henderson@linaro.org" References: <20250811112143.1577055-1-smail.aider@huawei.com> <20250811112143.1577055-2-smail.aider@huawei.com> <7402c0f3-326b-4a98-bd62-b8da998b4401@linaro.org> Content-Language: en-US From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=philmd@linaro.org; helo=mail-wr1-x42d.google.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 11/8/25 15:33, Smail AIDER wrote: > Hi Philippe, > > It is not just some refactoring. The last patch v3 is a squash of two previous patches v1 and v2. > Maybe I need to change the history description if not clear (I was talking from v3 point of view). > The purpose of the series is the main description itself. Please check the v1 below: > > https://patchew.org/QEMU/20250722131925.2119169-1-smail.aider@huawei.com/ Then please add a Cc tag (maintainer can do it if this v3 is OK, no need for v4): Cc: qemu-stable@nongnu.org > Other than that, the argument (is_pmcr) is correct. "isread" is not used in this case. Right, I missed it during review. Maybe we want to forward the arguments for clarity? -static CPAccessResult pmreg_access(CPUARMState *env, const ARMCPRegInfo *ri, - bool isread) +static CPAccessResult do_pmreg_access(CPUARMState *env, const ARMCPRegInfo *ri, + bool isread, bool is_pmcr) Anyhow I'll let Richard review. No objection. > > -- > Best Regards, > Smail AIDER > E-Mail: smail.aider@huawei.com > Operating System Researcher/Developer > Dresden Research Center, OS Kernel Lab > Huawei Technologies Co., Ltd > > -----Original Message----- > From: Philippe Mathieu-Daudé > Sent: Monday, August 11, 2025 2:36 PM > To: Smail AIDER ; qemu-devel@nongnu.org > Cc: Alexander Spyridakis ; zhangyue (BA) ; Liuyutao(DRC) ; mjt@tls.msk.ru; Peter Maydell ; qemu-arm@nongnu.org; richard.henderson@linaro.org > Subject: Re: [PATCH v3 1/1] target/arm: Trap PMCR when MDCR_EL2.TPMCR is set > > Hi Smail, > > (no need to Cc qemu-stable with this patch, it is a simple refactor) > > On 11/8/25 13:21, Smail AIDER via wrote: >> From: Smail AIDER via >> >> Trap PMCR_EL0 or PMCR accesses to EL2 when MDCR_EL2.TPMCR is set. >> Similar to MDCR_EL2.TPM, MDCR_EL2.TPMCR allows trapping EL0 and EL1 >> accesses to the PMCR register to EL2. >> >> Signed-off-by: Smail AIDER >> Reviewed-by: Richard Henderson >> Message-Id: <20250722131925.2119169-1-smail.aider@huawei.com> >> --- >> target/arm/cpregs-pmu.c | 33 +++++++++++++++++++++++++-------- >> 1 file changed, 25 insertions(+), 8 deletions(-) >> >> diff --git a/target/arm/cpregs-pmu.c b/target/arm/cpregs-pmu.c >> index 9c4431c18b..13392ddc4c 100644 >> --- a/target/arm/cpregs-pmu.c >> +++ b/target/arm/cpregs-pmu.c >> @@ -228,22 +228,27 @@ static bool event_supported(uint16_t number) >> return supported_event_map[number] != UNSUPPORTED_EVENT; >> } >> >> -static CPAccessResult pmreg_access(CPUARMState *env, const ARMCPRegInfo *ri, >> - bool isread) >> +static CPAccessResult do_pmreg_access(CPUARMState *env, bool is_pmcr) > > "bool is_pmcr" vs ... > >> +static CPAccessResult pmreg_access(CPUARMState *env, const ARMCPRegInfo *ri, >> + bool isread) > > ... "bool isread". > > I suppose we want to use "is_pmcr" here instead of "isread". > >> +{ >> + return do_pmreg_access(env, false); >> +} >> + >> +static CPAccessResult pmreg_access_pmcr(CPUARMState *env, const ARMCPRegInfo *ri, >> + bool isread) >> +{ >> + return do_pmreg_access(env, true); >> +} >> + >> static CPAccessResult pmreg_access_xevcntr(CPUARMState *env, >> const ARMCPRegInfo *ri, >> bool isread) >> @@ -1187,14 +1204,14 @@ void define_pm_cpregs(ARMCPU *cpu) >> .fgt = FGT_PMCR_EL0, >> .type = ARM_CP_IO | ARM_CP_ALIAS, >> .fieldoffset = offsetoflow32(CPUARMState, cp15.c9_pmcr), >> - .accessfn = pmreg_access, >> + .accessfn = pmreg_access_pmcr, >> .readfn = pmcr_read, .raw_readfn = raw_read, >> .writefn = pmcr_write, .raw_writefn = raw_write, >> }; >> const ARMCPRegInfo pmcr64 = { >> .name = "PMCR_EL0", .state = ARM_CP_STATE_AA64, >> .opc0 = 3, .opc1 = 3, .crn = 9, .crm = 12, .opc2 = 0, >> - .access = PL0_RW, .accessfn = pmreg_access, >> + .access = PL0_RW, .accessfn = pmreg_access_pmcr, >> .fgt = FGT_PMCR_EL0, >> .type = ARM_CP_IO, >> .fieldoffset = offsetof(CPUARMState, cp15.c9_pmcr), >