From: Pavel Fedin <p.fedin@samsung.com>
To: 'Peter Maydell' <peter.maydell@linaro.org>
Cc: 'Shlomo Pongratz' <shlomo.pongratz@huawei.com>,
'Shlomo Pongratz' <shlomopongratz@gmail.com>,
'QEMU Developers' <qemu-devel@nongnu.org>,
'Christoffer Dall' <christoffer.dall@linaro.org>,
'Eric Auger' <eric.auger@linaro.org>
Subject: Re: [Qemu-devel] [PATCH v7 6/6] Add gicversion option to virt machine
Date: Mon, 03 Aug 2015 10:19:09 +0300 [thread overview]
Message-ID: <00bd01d0cdbc$b0f97ab0$12ec7010$@samsung.com> (raw)
In-Reply-To: <CAFEAcA8pB7EAEqecTt6m2j99sffTnNWXsEB0C8V1mSdyjV3Y0Q@mail.gmail.com>
Hello!
> > gicdev = qdev_create(NULL, gictype);
> > - qdev_prop_set_uint32(gicdev, "revision", 2);
> > +
> > + for (i = 0; i < vbi->smp_cpus; i++) {
> > + CPUState *cpu = qemu_get_cpu(i);
> > + CPUARMState *env = cpu->env_ptr;
> > + env->nvic = gicdev;
> > + }
>
> We definitely need to come up with a something cleaner
> than this (which is ugly for two reasons
This could be done:
a) as property
b) as global variable because 'gicdev' is a single of its kind.
But, actually, this is currently only for TCG, which needs it in order to forward system register accesses to GICv3 code. Would it be OK if i just omit this assignment ?
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
next prev parent reply other threads:[~2015-08-03 7:19 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-24 9:55 [Qemu-devel] [PATCH v7 0/6] vGICv3 support Pavel Fedin
2015-07-24 9:55 ` [Qemu-devel] [PATCH v7 1/6] Merge memory_region_init_reservation() into memory_region_init_io() Pavel Fedin
2015-07-24 16:20 ` Peter Maydell
2015-07-24 9:55 ` [Qemu-devel] [PATCH v7 2/6] Implement GIC-500 base class Pavel Fedin
2015-07-24 16:37 ` Peter Maydell
2015-07-26 13:52 ` Pavel Fedin
2015-07-26 19:10 ` Peter Maydell
2015-07-31 15:38 ` Peter Maydell
2015-08-03 12:18 ` Pavel Fedin
2015-07-26 14:03 ` Pavel Fedin
2015-07-26 14:45 ` Shlomo Pongratz
2015-07-24 9:55 ` [Qemu-devel] [PATCH v7 3/6] Extract some reusable vGIC code Pavel Fedin
2015-07-24 9:55 ` [Qemu-devel] [PATCH v7 4/6] Introduce irqchip type specification for KVM Pavel Fedin
2015-07-24 16:42 ` Peter Maydell
2015-07-26 13:46 ` Pavel Fedin
2015-07-28 17:37 ` Peter Maydell
2015-07-24 9:55 ` [Qemu-devel] [PATCH v7 5/6] Initial implementation of vGICv3 Pavel Fedin
2015-07-30 17:00 ` Peter Maydell
2015-07-31 9:32 ` Pavel Fedin
2015-07-31 10:08 ` Peter Maydell
2015-07-31 10:22 ` Peter Maydell
2015-07-31 11:12 ` Pavel Fedin
2015-07-31 11:12 ` Peter Maydell
2015-07-31 11:15 ` Pavel Fedin
2015-07-31 11:24 ` Peter Maydell
2015-08-03 15:30 ` Pavel Fedin
2015-07-24 9:55 ` [Qemu-devel] [PATCH v7 6/6] Add gicversion option to virt machine Pavel Fedin
2015-07-31 15:44 ` Peter Maydell
2015-08-03 7:19 ` Pavel Fedin [this message]
2015-08-03 7:57 ` Peter Maydell
2015-08-03 11:41 ` Shlomo Pongratz
2015-08-03 12:01 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00bd01d0cdbc$b0f97ab0$12ec7010$@samsung.com' \
--to=p.fedin@samsung.com \
--cc=christoffer.dall@linaro.org \
--cc=eric.auger@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=shlomo.pongratz@huawei.com \
--cc=shlomopongratz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).