qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Michael Rolnik" <mrolnik@gmail.com>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: "Fam Zheng" <fam@euphon.net>,
	"Sarah Harris" <S.E.Harris@kent.ac.uk>,
	"Sagar Karandikar" <sagark@eecs.berkeley.edu>,
	"Joaquin de Andres" <me@xcancerberox.com.ar>,
	"QEMU Developers" <qemu-devel@nongnu.org>,
	"Alistair Francis" <Alistair.Francis@wdc.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Pavel Dovgalyuk" <dovgaluk@ispras.ru>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Aleksandar Markovic" <aleksandar.m.mail@gmail.com>,
	"Laurent Vivier" <lvivier@redhat.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	qemu-riscv@nongnu.org,
	"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Igor Mammedov" <imammedo@redhat.com>
Subject: Re: [PATCH rc2 00/25] target/avr merger
Date: Fri, 24 Jan 2020 13:49:37 +0100	[thread overview]
Message-ID: <00c08b6d-6ca2-7fa6-3dab-b834aea5a8d3@redhat.com> (raw)
In-Reply-To: <CAK4993iG+t7fZS=cekXfJVpDQ_L7jLu8i2V4mHVLbS-r69=AVg@mail.gmail.com>

On 1/24/20 12:41 PM, Michael Rolnik wrote:
> Tested-by: Michael Rolnik <mrolnik@gmail.com <mailto:mrolnik@gmail.com>>

Thanks a lot!

> The only thing I want to change is instead of -kernel put -bios in 
> qemu-doc.texi file. Should I send a new series?

Please do NOT :)

Richard can do the trivial fixup directly.

> On Fri, Jan 24, 2020 at 2:51 AM Philippe Mathieu-Daudé <f4bug@amsat.org 
> <mailto:f4bug@amsat.org>> wrote:
> 
>     This is the AVR port from Michael release (merge) candidate 2.
> 
>     Since v1 [1]:
>     - Addressed Thomas comments
>     - Fixed a non-critical bug in ATmega (incorrect SRAM base address)
>     - Added ELF parsing requested by Aleksandar
>     - Dropped default machine (as with the ARM port)
> 
>     Change since rc1:
> 
>     $ git backport-diff -u avr-rc1 -r origin/master..
>     Key:
>     [----] : patches are identical
>     [####] : number of functional differences between
>     upstream/downstream patch
>     [down] : patch is downstream-only
>     The flags [FC] indicate (F)unctional and (C)ontextual differences,
>     respectively
> 
>     001/25:[----] [--] 'target/avr: Add outward facing interfaces and
>     core CPU logic'
>     002/25:[----] [--] 'target/avr: Add instruction helpers'
>     003/25:[----] [--] 'target/avr: Add instruction translation -
>     Registers definition'
>     004/25:[----] [--] 'target/avr: Add instruction translation -
>     Arithmetic and Logic Instructions'
>     005/25:[----] [--] 'target/avr: Add instruction translation - Branch
>     Instructions'
>     006/25:[----] [--] 'target/avr: Add instruction translation - Data
>     Transfer Instructions'
>     007/25:[----] [--] 'target/avr: Add instruction translation - Bit
>     and Bit-test Instructions'
>     008/25:[----] [--] 'target/avr: Add instruction translation - MCU
>     Control Instructions'
>     009/25:[----] [--] 'target/avr: Add instruction translation - CPU
>     main translation function'
>     010/25:[----] [--] 'target/avr: Add instruction disassembly function'
>     011/25:[----] [--] 'hw/char: Add limited support for Atmel USART
>     peripheral'
>     012/25:[0045] [FC] 'hw/timer: Add limited support for Atmel 16 bit
>     timer peripheral'
>     013/25:[----] [--] 'hw/misc: Add Atmel power device'
>     014/25:[0024] [FC] 'target/avr: Add section about AVR into QEMU
>     documentation'
>     015/25:[----] [--] 'target/avr: Register AVR support with the rest
>     of QEMU'
>     016/25:[----] [--] 'target/avr: Add machine none test'
>     017/25:[0002] [FC] 'target/avr: Update MAINTAINERS file'
>     018/25:[down]      'hw/core/loader: Let load_elf populate the
>     processor-specific flags'
>     019/25:[down]      'hw/avr: Add helper to load raw/ELF firmware
>     binaries'
>     020/25:[0015] [FC] 'hw/avr: Add some ATmega microcontrollers'
>     021/25:[0040] [FC] 'hw/avr: Add some Arduino boards'
>     022/25:[----] [--] 'target/avr: Update build system'
>     023/25:[----] [--] 'tests/boot-serial-test: Test some Arduino boards
>     (AVR based)'
>     024/25:[----] [--] 'tests/acceptance: Test the Arduino MEGA2560 board'
>     025/25:[----] [--] '.travis.yml: Run the AVR acceptance tests'
> 
>     Repo: https://gitlab.com/philmd/qemu/commits/avr-rc2
> 
>     [1] https://www.mail-archive.com/qemu-devel@nongnu.org/msg672926.html
>     Supersedes: <20200123000307.11541-1-richard.henderson@linaro.org
>     <mailto:20200123000307.11541-1-richard.henderson@linaro.org>>
> 
>     Michael Rolnik (20):
>        target/avr: Add outward facing interfaces and core CPU logic
>        target/avr: Add instruction helpers
>        target/avr: Add instruction translation - Registers definition
>        target/avr: Add instruction translation - Arithmetic and Logic
>          Instructions
>        target/avr: Add instruction translation - Branch Instructions
>        target/avr: Add instruction translation - Data Transfer Instructions
>        target/avr: Add instruction translation - Bit and Bit-test
>          Instructions
>        target/avr: Add instruction translation - MCU Control Instructions
>        target/avr: Add instruction translation - CPU main translation
>          function
>        target/avr: Add instruction disassembly function
>        hw/char: Add limited support for Atmel USART peripheral
>        hw/timer: Add limited support for Atmel 16 bit timer peripheral
>        hw/misc: Add Atmel power device
>        target/avr: Add section about AVR into QEMU documentation
>        target/avr: Register AVR support with the rest of QEMU
>        target/avr: Add machine none test
>        target/avr: Update MAINTAINERS file
>        target/avr: Update build system
>        tests/boot-serial-test: Test some Arduino boards (AVR based)
>        tests/acceptance: Test the Arduino MEGA2560 board
> 
>     Philippe Mathieu-Daudé (5):
>        hw/core/loader: Let load_elf populate the processor-specific flags
>        hw/avr: Add helper to load raw/ELF firmware binaries
>        hw/avr: Add some ATmega microcontrollers
>        hw/avr: Add some Arduino boards
>        .travis.yml: Run the AVR acceptance tests
> 
>       qemu-doc.texi                    |   51 +
>       configure                        |    7 +
>       default-configs/avr-softmmu.mak  |    5 +
>       qapi/machine.json                |    3 +-
>       hw/avr/atmel_atmega.h            |   48 +
>       hw/avr/boot.h                    |   33 +
>       include/disas/dis-asm.h          |   19 +
>       include/elf.h                    |    2 +
>       include/hw/char/atmel_usart.h    |   93 +
>       include/hw/elf_ops.h             |    6 +-
>       include/hw/loader.h              |    6 +-
>       include/hw/misc/atmel_power.h    |   46 +
>       include/hw/timer/atmel_timer16.h |   94 +
>       include/sysemu/arch_init.h       |    1 +
>       target/avr/cpu-param.h           |   37 +
>       target/avr/cpu-qom.h             |   54 +
>       target/avr/cpu.h                 |  259 +++
>       target/avr/helper.h              |   29 +
>       arch_init.c                      |    2 +
>       hw/avr/arduino.c                 |  151 ++
>       hw/avr/atmel_atmega.c            |  470 +++++
>       hw/avr/boot.c                    |   74 +
>       hw/char/atmel_usart.c            |  320 ++++
>       hw/core/loader.c                 |   15 +-
>       hw/misc/atmel_power.c            |  112 ++
>       hw/riscv/boot.c                  |    2 +-
>       hw/timer/atmel_timer16.c         |  605 ++++++
>       target/avr/cpu.c                 |  826 ++++++++
>       target/avr/disas.c               |  246 +++
>       target/avr/gdbstub.c             |   84 +
>       target/avr/helper.c              |  347 ++++
>       target/avr/machine.c             |  121 ++
>       target/avr/translate.c           | 2997 ++++++++++++++++++++++++++++++
>       tests/qtest/boot-serial-test.c   |   11 +
>       tests/qtest/machine-none-test.c  |    1 +
>       .travis.yml                      |    2 +-
>       MAINTAINERS                      |   30 +
>       gdb-xml/avr-cpu.xml              |   49 +
>       hw/avr/Kconfig                   |    9 +
>       hw/avr/Makefile.objs             |    3 +
>       hw/char/Kconfig                  |    3 +
>       hw/char/Makefile.objs            |    1 +
>       hw/misc/Kconfig                  |    3 +
>       hw/misc/Makefile.objs            |    2 +
>       hw/timer/Kconfig                 |    3 +
>       hw/timer/Makefile.objs           |    2 +
>       target/avr/Makefile.objs         |   34 +
>       target/avr/insn.decode           |  182 ++
>       tests/acceptance/machine_avr6.py |   50 +
>       tests/qtest/Makefile.include     |    2 +
>       50 files changed, 7539 insertions(+), 13 deletions(-)
>       create mode 100644 default-configs/avr-softmmu.mak
>       create mode 100644 hw/avr/atmel_atmega.h
>       create mode 100644 hw/avr/boot.h
>       create mode 100644 include/hw/char/atmel_usart.h
>       create mode 100644 include/hw/misc/atmel_power.h
>       create mode 100644 include/hw/timer/atmel_timer16.h
>       create mode 100644 target/avr/cpu-param.h
>       create mode 100644 target/avr/cpu-qom.h
>       create mode 100644 target/avr/cpu.h
>       create mode 100644 target/avr/helper.h
>       create mode 100644 hw/avr/arduino.c
>       create mode 100644 hw/avr/atmel_atmega.c
>       create mode 100644 hw/avr/boot.c
>       create mode 100644 hw/char/atmel_usart.c
>       create mode 100644 hw/misc/atmel_power.c
>       create mode 100644 hw/timer/atmel_timer16.c
>       create mode 100644 target/avr/cpu.c
>       create mode 100644 target/avr/disas.c
>       create mode 100644 target/avr/gdbstub.c
>       create mode 100644 target/avr/helper.c
>       create mode 100644 target/avr/machine.c
>       create mode 100644 target/avr/translate.c
>       create mode 100644 gdb-xml/avr-cpu.xml
>       create mode 100644 hw/avr/Kconfig
>       create mode 100644 hw/avr/Makefile.objs
>       create mode 100644 target/avr/Makefile.objs
>       create mode 100644 target/avr/insn.decode
>       create mode 100644 tests/acceptance/machine_avr6.py
> 
>     -- 
>     2.21.1
> 
> 
> 
> -- 
> Best Regards,
> Michael Rolnik



  reply	other threads:[~2020-01-24 12:51 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-24  0:51 [PATCH rc2 00/25] target/avr merger Philippe Mathieu-Daudé
2020-01-24  0:51 ` [PATCH rc2 01/25] target/avr: Add outward facing interfaces and core CPU logic Philippe Mathieu-Daudé
2020-01-25 10:48   ` Aleksandar Markovic
2020-01-25 17:08     ` Thomas Huth
2020-01-26 12:15   ` Joaquin de Andres
2020-01-27  2:25     ` Aleksandar Markovic
2020-01-27  8:53     ` Michael Rolnik
2020-01-27  9:24       ` Joaquin de Andres
2020-01-27  9:48         ` Michael Rolnik
2020-01-27 10:39           ` Joaquin de Andres
2020-01-27 13:27   ` Joaquin de Andres
2020-01-27 13:38     ` Michael Rolnik
2020-01-31  1:22       ` Philippe Mathieu-Daudé
2020-01-24  0:51 ` [PATCH rc2 02/25] target/avr: Add instruction helpers Philippe Mathieu-Daudé
2020-01-24  0:51 ` [PATCH rc2 03/25] target/avr: Add instruction translation - Registers definition Philippe Mathieu-Daudé
2020-01-24  0:51 ` [PATCH rc2 04/25] target/avr: Add instruction translation - Arithmetic and Logic Instructions Philippe Mathieu-Daudé
2020-01-24  0:51 ` [PATCH rc2 05/25] target/avr: Add instruction translation - Branch Instructions Philippe Mathieu-Daudé
2020-01-24  0:51 ` [PATCH rc2 06/25] target/avr: Add instruction translation - Data Transfer Instructions Philippe Mathieu-Daudé
2020-01-24  0:51 ` [PATCH rc2 07/25] target/avr: Add instruction translation - Bit and Bit-test Instructions Philippe Mathieu-Daudé
2020-01-24  0:51 ` [PATCH rc2 08/25] target/avr: Add instruction translation - MCU Control Instructions Philippe Mathieu-Daudé
2020-01-24  0:51 ` [PATCH rc2 09/25] target/avr: Add instruction translation - CPU main translation function Philippe Mathieu-Daudé
2020-01-24  0:51 ` [PATCH rc2 10/25] target/avr: Add instruction disassembly function Philippe Mathieu-Daudé
2020-01-24  0:51 ` [PATCH rc2 11/25] hw/char: Add limited support for Atmel USART peripheral Philippe Mathieu-Daudé
2020-01-24  0:51 ` [PATCH rc2 12/25] hw/timer: Add limited support for Atmel 16 bit timer peripheral Philippe Mathieu-Daudé
2020-01-24  8:16   ` Thomas Huth
2020-01-24 12:50     ` Philippe Mathieu-Daudé
2020-01-30 22:45     ` Aleksandar Markovic
2020-01-24 10:42   ` Alex Bennée
2020-01-24 10:51     ` Philippe Mathieu-Daudé
2020-01-24 12:07       ` Sarah Harris
2020-01-30 22:44         ` Aleksandar Markovic
2020-01-31 11:20           ` Philippe Mathieu-Daudé
2020-01-24 12:52     ` Philippe Mathieu-Daudé
2020-01-24  0:51 ` [PATCH rc2 13/25] hw/misc: Add Atmel power device Philippe Mathieu-Daudé
2020-01-24  0:51 ` [PATCH rc2 14/25] target/avr: Add section about AVR into QEMU documentation Philippe Mathieu-Daudé
2020-01-24  7:14   ` Thomas Huth
2020-01-24 11:50     ` Michael Rolnik
2020-01-24  0:51 ` [PATCH rc2 15/25] target/avr: Register AVR support with the rest of QEMU Philippe Mathieu-Daudé
2020-01-24  0:51 ` [PATCH rc2 16/25] target/avr: Add machine none test Philippe Mathieu-Daudé
2020-01-24  0:51 ` [PATCH rc2 17/25] target/avr: Update MAINTAINERS file Philippe Mathieu-Daudé
2020-01-24  0:51 ` [PATCH rc2 18/25] hw/core/loader: Let load_elf populate the processor-specific flags Philippe Mathieu-Daudé
2020-01-24  0:51 ` [PATCH rc2 19/25] hw/avr: Add helper to load raw/ELF firmware binaries Philippe Mathieu-Daudé
2020-01-24  0:51 ` [PATCH rc2 20/25] hw/avr: Add some ATmega microcontrollers Philippe Mathieu-Daudé
2020-01-26 14:46   ` Aleksandar Markovic
2020-01-27  7:59     ` Philippe Mathieu-Daudé
2020-01-27  8:04       ` Aleksandar Markovic
2020-01-24  0:51 ` [PATCH rc2 21/25] hw/avr: Add some Arduino boards Philippe Mathieu-Daudé
2020-01-25  9:32   ` Joaquin de Andres
2020-01-24  0:51 ` [PATCH rc2 22/25] target/avr: Update build system Philippe Mathieu-Daudé
2020-01-24 10:59   ` Alex Bennée
2020-01-24  0:51 ` [PATCH rc2 23/25] tests/boot-serial-test: Test some Arduino boards (AVR based) Philippe Mathieu-Daudé
2020-01-24  0:51 ` [PATCH rc2 24/25] tests/acceptance: Test the Arduino MEGA2560 board Philippe Mathieu-Daudé
2020-01-24  0:51 ` [PATCH rc2 25/25] .travis.yml: Run the AVR acceptance tests Philippe Mathieu-Daudé
2020-01-24  1:02 ` [PATCH rc2 00/25] target/avr merger Philippe Mathieu-Daudé
2020-01-24  7:12 ` Thomas Huth
2020-01-24 11:41 ` Michael Rolnik
2020-01-24 12:49   ` Philippe Mathieu-Daudé [this message]
2020-01-24 14:11     ` Michael Rolnik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=00c08b6d-6ca2-7fa6-3dab-b834aea5a8d3@redhat.com \
    --to=philmd@redhat.com \
    --cc=Alistair.Francis@wdc.com \
    --cc=S.E.Harris@kent.ac.uk \
    --cc=aleksandar.m.mail@gmail.com \
    --cc=alex.bennee@linaro.org \
    --cc=armbru@redhat.com \
    --cc=dovgaluk@ispras.ru \
    --cc=ehabkost@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=fam@euphon.net \
    --cc=imammedo@redhat.com \
    --cc=kbastian@mail.uni-paderborn.de \
    --cc=lvivier@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=me@xcancerberox.com.ar \
    --cc=mrolnik@gmail.com \
    --cc=palmer@dabbelt.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=sagark@eecs.berkeley.edu \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).