From: Peter Crosthwaite <crosthwaitepeter@gmail.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org,
Peter Crosthwaite <crosthwaite.peter@gmail.com>,
afaerber@suse.de, edgar.iglesias@gmail.com
Subject: [Qemu-devel] [PATCH 2/5] gdbstub: Use cpu_set_pc helper
Date: Sun, 14 Jun 2015 20:48:29 -0700 [thread overview]
Message-ID: <00c96d447252bc1333e14e626611f4f5a58f9bf5.1434339500.git.crosthwaite.peter@gmail.com> (raw)
In-Reply-To: <cover.1434339500.git.crosthwaite.peter@gmail.com>
In-Reply-To: <cover.1434339500.git.crosthwaite.peter@gmail.com>
Use the cpu_set_pc helper which will take care of CPUClass retrieval
for us.
Signed-off-by: Peter Crosthwaite <crosthwaite.peter@gmail.com>
---
gdbstub.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/gdbstub.c b/gdbstub.c
index 75563db..ceb60ac 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -754,12 +754,9 @@ static void gdb_breakpoint_remove_all(void)
static void gdb_set_cpu_pc(GDBState *s, target_ulong pc)
{
CPUState *cpu = s->c_cpu;
- CPUClass *cc = CPU_GET_CLASS(cpu);
cpu_synchronize_state(cpu);
- if (cc->set_pc) {
- cc->set_pc(cpu, pc);
- }
+ cpu_set_pc(cpu, pc, NULL);
}
static CPUState *find_cpu(uint32_t thread_id)
--
1.9.1
next prev parent reply other threads:[~2015-06-15 3:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-15 3:48 [Qemu-devel] [PATCH 0/5] qom-cpu: Wrap set_pc hook and use in bootloaders Peter Crosthwaite
2015-06-15 3:48 ` [Qemu-devel] [PATCH 1/5] qom: cpu: Add wrapper to the set-pc hook Peter Crosthwaite
2015-06-15 3:48 ` Peter Crosthwaite [this message]
2015-06-15 3:48 ` [Qemu-devel] [PATCH 3/5] arm: Support thumb in set_pc routines Peter Crosthwaite
2015-06-15 7:36 ` Peter Maydell
2015-06-15 22:41 ` Peter Crosthwaite
2015-06-15 3:48 ` [Qemu-devel] [PATCH 4/5] arm: boot: Use cpu_set_pc Peter Crosthwaite
2015-06-15 7:37 ` Peter Maydell
2015-06-15 3:48 ` [Qemu-devel] [PATCH 5/5] microblaze: " Peter Crosthwaite
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00c96d447252bc1333e14e626611f4f5a58f9bf5.1434339500.git.crosthwaite.peter@gmail.com \
--to=crosthwaitepeter@gmail.com \
--cc=afaerber@suse.de \
--cc=crosthwaite.peter@gmail.com \
--cc=edgar.iglesias@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).