From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51835)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <p.fedin@samsung.com>) id 1ZRwz7-000204-J4
	for qemu-devel@nongnu.org; Wed, 19 Aug 2015 02:36:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <p.fedin@samsung.com>) id 1ZRwz2-0000PK-Gj
	for qemu-devel@nongnu.org; Wed, 19 Aug 2015 02:36:29 -0400
Received: from mailout2.w1.samsung.com ([210.118.77.12]:13760)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <p.fedin@samsung.com>) id 1ZRwz2-0000Om-Af
	for qemu-devel@nongnu.org; Wed, 19 Aug 2015 02:36:24 -0400
Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245])
	by mailout2.w1.samsung.com
	(Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5
	2014)) with ESMTP id <0NTB0032RH0KZTA0@mailout2.w1.samsung.com> for
	qemu-devel@nongnu.org; Wed, 19 Aug 2015 07:36:20 +0100 (BST)
From: Pavel Fedin <p.fedin@samsung.com>
References: <cover.1439904588.git.p.fedin@samsung.com>
	<76a96dc06cc55504cbe2f46165b2b171712f78e9.1439904588.git.p.fedin@samsung.com>
	<55D35512.1000903@linaro.org>
In-reply-to: <55D35512.1000903@linaro.org>
Date: Wed, 19 Aug 2015 09:36:19 +0300
Message-id: <00d201d0da49$5bb60e30$13222a90$@samsung.com>
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii
Content-transfer-encoding: 7bit
Content-language: ru
Subject: Re: [Qemu-devel] [PATCH v10 2/5] intc/gic: Extract some
 reusable	vGIC code
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: 'Eric Auger' <eric.auger@linaro.org>, qemu-devel@nongnu.org
Cc: 'Peter Maydell' <peter.maydell@linaro.org>, 'Shlomo Pongratz' <shlomopongratz@gmail.com>, 'Christoffer Dall' <christoffer.dall@linaro.org>, 'Shlomo Pongratz' <shlomo.pongratz@huawei.com>

 Hello!

> I think it would be worth justifying the changes in signature:
> removal of GICState* due to the introduction of  GICV3State and also
> justify replacement of uint32_t *val into void*.

 I described it in the cover letter. Right now you don't see usage for it, but here i started
prototyping live migration, and in some cases 'val' is going to be uint64_t. This is because
GICD_IROUTER registers are 64 bits wide. kvm_gic_access() by itself does not dereference the
pointer, just passes it to the kernel, therefore i decided to make it type-agnostic.

> what is the point of moving kvm_gicd_access and kvm_gicc_access here? If
> I am not mistaken, they only are used in arm_gic_kvm.c? I think they can
> stay static in arm_gic_kvm.c?

 They will be used in future for live migration, at least kvm_gicd_access. kvm_gicc_access just
accompanies it to keep a single style for both.

Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia