From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,PDS_BAD_THREAD_QP_64,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4ACDC433E0 for ; Mon, 18 Jan 2021 15:52:08 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 37CEB22B39 for ; Mon, 18 Jan 2021 15:52:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 37CEB22B39 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35666 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l1Wp5-0003HK-4I for qemu-devel@archiver.kernel.org; Mon, 18 Jan 2021 10:52:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47994) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1Wmp-0002Eo-8W; Mon, 18 Jan 2021 10:49:47 -0500 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]:41607) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l1Wmm-0000kB-VB; Mon, 18 Jan 2021 10:49:47 -0500 Received: by mail-wr1-x433.google.com with SMTP id a12so16895462wrv.8; Mon, 18 Jan 2021 07:49:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-transfer-encoding:thread-index :content-language; bh=bueLRhGnMFSaD5BV6OB46NiQT5MIKIabH3Mj8UAiQbk=; b=KC6DuXLelzuof+WkJU5Uk/ENpVF62l3gZLtnvRvejynd67fvkZSeF/FAfFXG3viYJb 4K+QuzI2u3D6KNaklkyNpCQj+X6GGJ5Nr9mKjF9LWu9n78t1LJu6zJG5+RIeFHyDtQoF v6BTM4vjArWMELLWinc90nnnVzha4M6xRb5eAzgAtJCp8GTM+1L04GkW0thymWZGqdKR TooM0GKVkBkwG+QjUPOZIZkkPq0sLnm5i4U66lEBinBBZ8XJnGNE/2oZQbJUuIcEz9Dr lp/vQGAj8PwzmCfAg9euH7RwDrqk2yw/Qlrh3AfLD0W6NXCd4SjjrhThoXMqtlAYo20A i2kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:to:cc:references:in-reply-to :subject:date:message-id:mime-version:content-transfer-encoding :thread-index:content-language; bh=bueLRhGnMFSaD5BV6OB46NiQT5MIKIabH3Mj8UAiQbk=; b=T57uX/TG8HgISyq9ECriAWWF8ILwv6V6CG7oYjkVn+U8Xi5DyhLrKKYCisy4VTPR1z BFHVC5IK38Fg5s+saWoQ07Seaf3K9vIUtJRzgbV7mfqTsfxIIgK00vMh2T8eceyvx6JR DVt2OVH3yRQEcnKID2dK7mi4Baq/et1SHdnftDG/2qS7amqH0Lo4jpM7GlMT0Zlvsvfc LrHslQCZjJgG/EJVC6RbF+6bs/3mh0oDgNXi1u/cpmAHb0bBcaJljmIovtqJduCC0CtI uDkZ6QvunFnfR7y59wwvhQvUo9FHLr7lwO/K4eDo6WlYG2mn5QjwuV/Lf4L7hfCjlCOI HRig== X-Gm-Message-State: AOAM5336dnuKqc2Bb4BiXA8o3+qPkTF1NGt0toyO+y0kbwH0X6qI9E/w ejwKsNfcpyxWMdLhGrTfcJI= X-Google-Smtp-Source: ABdhPJxiPC2OChaveXMqD0rIthafoYXmtdcNoEYh9vEMEVKUJD26R+IXQm6fjLZmNOUugiqBSkMK1A== X-Received: by 2002:adf:f681:: with SMTP id v1mr97027wrp.133.1610984982739; Mon, 18 Jan 2021 07:49:42 -0800 (PST) Received: from CBGR90WXYV0 (host86-183-162-242.range86-183.btcentralplus.com. [86.183.162.242]) by smtp.gmail.com with ESMTPSA id r126sm12606693wma.48.2021.01.18.07.49.41 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Jan 2021 07:49:42 -0800 (PST) From: Paul Durrant X-Google-Original-From: "Paul Durrant" To: "'Roger Pau Monne'" , References: <20210118153330.82324-1-roger.pau@citrix.com> In-Reply-To: <20210118153330.82324-1-roger.pau@citrix.com> Subject: RE: [PATCH] xen-block: fix reporting of discard feature Date: Mon, 18 Jan 2021 15:49:41 -0000 Message-ID: <00d701d6edb1$894122f0$9bc368d0$@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQKr9v/Nt+LMBjUs9/3Ji6x60nJqgaiDdLPw Content-Language: en-gb Received-SPF: pass client-ip=2a00:1450:4864:20::433; envelope-from=xadimgnik@gmail.com; helo=mail-wr1-x433.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: paul@xen.org Cc: 'Kevin Wolf' , 'Stefano Stabellini' , qemu-block@nongnu.org, 'Arthur Borsboom' , 'Max Reitz' , 'Anthony Perard' , xen-devel@lists.xenproject.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" > -----Original Message----- > From: Roger Pau Monne > Sent: 18 January 2021 15:34 > To: qemu-devel@nongnu.org > Cc: Roger Pau Monne ; Arthur Borsboom = ; Stefano > Stabellini ; Anthony Perard = ; Paul Durrant > ; Kevin Wolf ; Max Reitz = ; xen- > devel@lists.xenproject.org; qemu-block@nongnu.org > Subject: [PATCH] xen-block: fix reporting of discard feature >=20 > Linux blkfront expects both "discard-granularity" and > "discard-alignment" present on xenbus in order to properly enable the > feature, not exposing "discard-alignment" left some Linux blkfront > versions with a broken discard setup. This has also been addressed in > Linux with: >=20 > = https://lore.kernel.org/lkml/20210118151528.81668-1-roger.pau@citrix.com/= T/#u >=20 > Fix QEMU to report a "discard-alignment" of 0, in order for it to work > with older Linux frontends. >=20 > Reported-by: Arthur Borsboom > Signed-off-by: Roger Pau Monn=C3=A9 Reviewed-by: Paul Durrant > --- > Cc: Stefano Stabellini > Cc: Anthony Perard > Cc: Paul Durrant > Cc: Kevin Wolf > Cc: Max Reitz > Cc: xen-devel@lists.xenproject.org > Cc: qemu-block@nongnu.org > --- > hw/block/xen-block.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/hw/block/xen-block.c b/hw/block/xen-block.c > index 718d886e5c..246d9c23a2 100644 > --- a/hw/block/xen-block.c > +++ b/hw/block/xen-block.c > @@ -253,6 +253,7 @@ static void xen_block_realize(XenDevice *xendev, = Error **errp) > xen_device_backend_printf(xendev, "feature-discard", "%u", = 1); > xen_device_backend_printf(xendev, "discard-granularity", = "%u", > conf->discard_granularity); > + xen_device_backend_printf(xendev, "discard-alignment", "%u", = 0); > } >=20 > xen_device_backend_printf(xendev, "feature-flush-cache", "%u", = 1); > -- > 2.29.2