From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53245)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <p.fedin@samsung.com>) id 1ZkD76-0006Nm-0R
	for qemu-devel@nongnu.org; Thu, 08 Oct 2015 11:29:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <p.fedin@samsung.com>) id 1ZkD6e-0001Rh-4e
	for qemu-devel@nongnu.org; Thu, 08 Oct 2015 11:28:11 -0400
Received: from mailout4.w1.samsung.com ([210.118.77.14]:13236)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <p.fedin@samsung.com>) id 1ZkD6d-0001PB-Vw
	for qemu-devel@nongnu.org; Thu, 08 Oct 2015 11:27:44 -0400
Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245])
	by mailout4.w1.samsung.com
	(Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5
	2014)) with ESMTP id <0NVW00HW5QY5AQB0@mailout4.w1.samsung.com> for
	qemu-devel@nongnu.org; Thu, 08 Oct 2015 16:27:41 +0100 (BST)
From: Pavel Fedin <p.fedin@samsung.com>
References: <1444313344-16196-1-git-send-email-berrange@redhat.com>
In-reply-to: <1444313344-16196-1-git-send-email-berrange@redhat.com>
Date: Thu, 08 Oct 2015 18:27:39 +0300
Message-id: <00d901d101dd$debc7d30$9c357790$@samsung.com>
MIME-version: 1.0
Content-type: text/plain; charset=UTF-8
Content-transfer-encoding: quoted-printable
Content-language: ru
Subject: Re: [Qemu-devel] [PATCH v3 0/5] qom: more efficient object
	property	handling
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "'Daniel P. Berrange'" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: =?UTF-8?Q?'Andreas_F=C3=A4rber'?= <afaerber@suse.de>

 Hi!

 Just got test report from my colleague, he forgot to specify =
--target-list=3Daarch64-softmmu to configure and tried to build =
everything. Looks like there are more property iterations done by hand =
in PowerPC code:
--- cut ---
In file included from /home/igor/qemu/include/qom/object.h:20:0,
                  from /home/igor/qemu/include/hw/ppc/spapr_drc.h:15,
                  from /home/igor/qemu/hw/ppc/spapr_drc.c:13:
/home/igor/qemu/hw/ppc/spapr_drc.c: In function =
=E2=80=98spapr_drc_populate_dt=E2=80=99:
/home/igor/qemu/include/qemu/queue.h:419:29: error: request for member=20
=E2=80=98tqh_first=E2=80=99 in something not a structure or union
          for ((var) =3D ((head)->tqh_first);                            =
   \
                              ^
/home/igor/qemu/hw/ppc/spapr_drc.c:683:5: note: in expansion of macro=20
=E2=80=98QTAILQ_FOREACH=E2=80=99
      QTAILQ_FOREACH(prop, &root_container->properties, node) {
      ^
/home/igor/qemu/include/qemu/queue.h:421:31: error: =
=E2=80=98ObjectProperty=E2=80=99 has=20
no member named =E2=80=98node=E2=80=99
                  (var) =3D ((var)->field.tqe_next))
                                ^
/home/igor/qemu/hw/ppc/spapr_drc.c:683:5: note: in expansion of macro=20
=E2=80=98QTAILQ_FOREACH=E2=80=99
      QTAILQ_FOREACH(prop, &root_container->properties, node) {
      ^
/home/igor/qemu/rules.mak:57: recipe for target 'hw/ppc/spapr_drc.o' =
failed
make[1]: *** [hw/ppc/spapr_drc.o] Error 1
Makefile:184: recipe for target 'subdir-ppc64-softmmu' failed
--- cut ---

 Actually, he was building version with my standalone patch, but i have =
checked your series, it also doesn't touch SPAPR code.

 Tested-by: Igor Skalkin <i.skalkin@samsung.com>

Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia