From: Richard Henderson <richard.henderson@linaro.org>
To: Chinmay Rath <rathc@linux.ibm.com>, qemu-ppc@nongnu.org
Cc: qemu-devel@nongnu.org, npiggin@gmail.com, danielhb413@gmail.com,
harshpb@linux.ibm.com
Subject: Re: [PATCH 4/8] target/ppc: Move neg, darn, mod{sw, uw} to decodetree.
Date: Tue, 16 Apr 2024 11:25:50 -0700 [thread overview]
Message-ID: <00d9243d-bc6b-44c8-a53c-15ca702058de@linaro.org> (raw)
In-Reply-To: <20240416063927.99428-5-rathc@linux.ibm.com>
On 4/15/24 23:39, Chinmay Rath wrote:
> Moving the below instructions to decodetree specification :
>
> neg[o][.] : XO-form
> mod{sw, uw}, darn : X-form
>
> The changes were verified by validating that the tcg ops generated by those
> instructions remain the same, which were captured with the '-d in_asm,op' flag.
>
> Signed-off-by: Chinmay Rath<rathc@linux.ibm.com>
> ---
> target/ppc/helper.h | 4 +-
> target/ppc/insn32.decode | 8 ++++
> target/ppc/int_helper.c | 4 +-
> target/ppc/translate.c | 56 ----------------------
> target/ppc/translate/fixedpoint-impl.c.inc | 44 +++++++++++++++++
> 5 files changed, 56 insertions(+), 60 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2024-04-16 18:26 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 6:39 [PATCH 0/8] target/ppc: Move fixed-point insns to decodetree Chinmay Rath
2024-04-16 6:39 ` [PATCH 1/8] target/ppc: Move mul{li, lw, lwo, hw, hwu} instructions " Chinmay Rath
2024-04-16 17:56 ` Richard Henderson
2024-04-19 9:08 ` Chinmay Rath
2024-04-16 6:39 ` [PATCH 2/8] target/ppc: Make divw[u] handler method decodetree compatible Chinmay Rath
2024-04-16 17:57 ` Richard Henderson
2024-04-19 9:17 ` Chinmay Rath
2024-04-16 6:39 ` [PATCH 3/8] target/ppc: Move divw[u, e, eu] instructions to decodetree Chinmay Rath
2024-04-16 18:19 ` Richard Henderson
2024-04-19 9:18 ` Chinmay Rath
2024-04-16 6:39 ` [PATCH 4/8] target/ppc: Move neg, darn, mod{sw, uw} " Chinmay Rath
2024-04-16 18:25 ` Richard Henderson [this message]
2024-04-19 9:18 ` Chinmay Rath
2024-04-16 6:39 ` [PATCH 5/8] target/ppc: Move multiply fixed-point insns (64-bit operands) " Chinmay Rath
2024-04-16 18:36 ` Richard Henderson
2024-04-19 9:25 ` Chinmay Rath
2024-04-20 15:51 ` Richard Henderson
2024-04-22 6:32 ` Chinmay Rath
2024-04-16 6:39 ` [PATCH 6/8] target/ppc: Move div/mod fixed-point insns (64 bits " Chinmay Rath
2024-04-16 18:38 ` Richard Henderson
2024-04-19 9:26 ` Chinmay Rath
2024-04-16 6:39 ` [PATCH 7/8] target/ppc: Move cmp{rb, eqb}, tw[i], td[i], isel instructions " Chinmay Rath
2024-04-16 19:20 ` Richard Henderson
2024-04-19 9:28 ` Chinmay Rath
2024-04-16 6:39 ` [PATCH 8/8] target/ppc: Move logical fixed-point " Chinmay Rath
2024-04-16 19:35 ` Richard Henderson
2024-04-19 9:29 ` Chinmay Rath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00d9243d-bc6b-44c8-a53c-15ca702058de@linaro.org \
--to=richard.henderson@linaro.org \
--cc=danielhb413@gmail.com \
--cc=harshpb@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rathc@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).