From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60299)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <p.fedin@samsung.com>) id 1a3I9w-0000Hu-4o
	for qemu-devel@nongnu.org; Mon, 30 Nov 2015 01:42:00 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <p.fedin@samsung.com>) id 1a3I9s-0004lu-Tw
	for qemu-devel@nongnu.org; Mon, 30 Nov 2015 01:42:00 -0500
Received: from mailout3.w1.samsung.com ([210.118.77.13]:22583)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <p.fedin@samsung.com>) id 1a3I9s-0004lq-Ny
	for qemu-devel@nongnu.org; Mon, 30 Nov 2015 01:41:56 -0500
Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245])
	by mailout3.w1.samsung.com
	(Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5
	2014)) with ESMTP id <0NYM00AA97XS8Q00@mailout3.w1.samsung.com> for
	qemu-devel@nongnu.org; Mon, 30 Nov 2015 06:41:52 +0000 (GMT)
From: Pavel Fedin <p.fedin@samsung.com>
References: <cover.1448359515.git.p.fedin@samsung.com>
	<5fc3dbe99380a9c82c3758af219ad13aac831b67.1448359515.git.p.fedin@samsung.com>
	<CAFEAcA-LuidMgNo6-z1fdR96aCptWt8Zzei8hH-kcgQE7c3vPw@mail.gmail.com>
In-reply-to: <CAFEAcA-LuidMgNo6-z1fdR96aCptWt8Zzei8hH-kcgQE7c3vPw@mail.gmail.com>
Date: Mon, 30 Nov 2015 09:41:50 +0300
Message-id: <00e801d12b3a$320522f0$960f68d0$@samsung.com>
MIME-version: 1.0
Content-type: text/plain; charset=UTF-8
Content-transfer-encoding: quoted-printable
Content-language: ru
Subject: Re: [Qemu-devel] [RFC PATCH v3 3/5] kvm_arm: Pass requester ID to
 MSI routing functions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: 'Peter Maydell' <peter.maydell@linaro.org>
Cc: 'Diana Craciun' <diana.craciun@freescale.com>, 'Shlomo Pongratz' <shlomo.pongratz@huawei.com>, 'Shlomo Pongratz' <shlomopongratz@gmail.com>, 'QEMU Developers' <qemu-devel@nongnu.org>

 Hello!

> > +        route->u.msi.devid =3D pci_requester_id(dev);
> > +    }
>=20
> Is there anything that would go wrong if we just always set
> the u.msi.devid and the VALID_DEVID flag? (ie do we need the
> kvm_arm_msi_use_devid bool?)

 Current kernels always make sure that flags =3D=3D 0, or they simply =
return -EINVAL. Therefore, for backwards compatibility we set the flag =
only if we know that we need it.

Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia