Re: [RFC PATCH v4 4/4] tests/avocado: Add test for amigaone board

["Cédric Le Goater" <clg@kaod.org>]

On 10/18/23 07:58, Thomas Huth wrote:
> Please add a short patch description if this moves from RFC to a real patch
> 
> On 17/10/2023 21.06, BALATON Zoltan wrote:
>> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
>> ---
>> I have no idea if this works so testing and corrections are welcome
> 
> Why don't you test it on your own? I think this should be sufficient:
> 
>   make check-avocado AVOCADO_TAGS=machine:amigaone

Test doesn't pass :

Fetching asset from tests/avocado/ppc_amiga.py:AmigaOneMachine.test_ppc_amigaone
JOB ID     : 39645d61f6f6c90ae87e3a48fe29beb16146aa73
JOB LOG    : /home/legoater/work/qemu/qemu.git/build/tests/results/job-2023-10-18T05.51-39645d6/job.log
  (1/1) tests/avocado/ppc_amiga.py:AmigaOneMachine.test_ppc_amigaone:  ERROR: file is not an archive (0.10 s)
Interrupting job (failfast).
RESULTS    : PASS 0 | ERROR 1 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB TIME   : 2.53 s

C.

> 
>> but this could be a basic test. Booting further is a bit more involved
>> as we'd need alternative VGA BIOS and selecting menu items in the
>> firmware to allow CD boot so I did not try to automate that.
>>
>> This could be simpler if the u-boot-amigaone.bin could be added to
>> pc-bios. It's GPL so should be OK to include and distribute but irs
>> sources seem to be lost and could not be recovered or reconstructed so
>> we only have this binary. Who should be able to decide about that?
> 
> I'm sorry, but if the sources are not available anymore, then I think it will not be possible to ship the binary in the QEMU tarball - since the GPL requires that the distributor of the binary can also provide the sources on request.
> 
>   Thomas
>