From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60927) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZKNvh-00080q-53 for qemu-devel@nongnu.org; Wed, 29 Jul 2015 05:45:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZKNve-0003Ij-BR for qemu-devel@nongnu.org; Wed, 29 Jul 2015 05:45:41 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:25322) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZKNve-0003IS-5w for qemu-devel@nongnu.org; Wed, 29 Jul 2015 05:45:38 -0400 Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout3.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NS800GWYTRZ4H10@mailout3.w1.samsung.com> for qemu-devel@nongnu.org; Wed, 29 Jul 2015 10:45:35 +0100 (BST) From: Pavel Fedin References: <015a01d0c85c$b52b61d0$1f822570$@samsung.com> <20150727152658.3f3740f7@nial.brq.redhat.com> <00da01d0c9dc$b39503e0$1abf0ba0$@samsung.com> In-reply-to: Date: Wed, 29 Jul 2015 12:45:34 +0300 Message-id: <00f401d0c9e3$517efba0$f47cf2e0$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: quoted-printable Content-language: ru Subject: Re: [Qemu-devel] [PATCH v3] hw/arm/virt: Add high MMIO PCI region List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: 'Peter Maydell' Cc: 'Igor Mammedov' , 'Alexander Graf' , "'Michael S. Tsirkin'" , 'QEMU Developers' , 'Paolo Bonzini' > > because i discovered problems with 32-bit guests. They simply = truncate > > high word and end up in attempt to put PCI at 0x00000000 - = 0xFFFFFFFF, fail, > > and do not work of course. So, my next version will have high MMIO > > only for 64-bit guests. >=20 > That sounds like a guest bug to me. If the device tree says that > addresses are two-cells wide then the code reading it ought to > read both cells, not just ignore the top 32 bits... May be. It's old kernel, v3.19, but still it works as it works. We = could, of course, have some machine option, but personally i currently = care only about 64 bits, so for simplicity let's leave alone 32 bits for = now. When more important things are settled down, adding an option will = not be a problem. =20 Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia