From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41951) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoqwQ-0001Yx-Nc for qemu-devel@nongnu.org; Wed, 21 Oct 2015 06:48:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZoqwN-0004qx-Et for qemu-devel@nongnu.org; Wed, 21 Oct 2015 06:48:22 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:28082) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoqwN-0004qp-8u for qemu-devel@nongnu.org; Wed, 21 Oct 2015 06:48:19 -0400 Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout2.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NWK009I6GOG3L60@mailout2.w1.samsung.com> for qemu-devel@nongnu.org; Wed, 21 Oct 2015 11:48:16 +0100 (BST) From: Pavel Fedin References: <1445396964-21189-1-git-send-email-shlomopongratz@gmail.com> <009e01d10bcc$8c4326a0$a4c973e0$@samsung.com> In-reply-to: Date: Wed, 21 Oct 2015 13:48:14 +0300 Message-id: <00f601d10bed$fd8ac5e0$f8a051a0$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: quoted-printable Content-language: ru Subject: Re: [Qemu-devel] [PATCH RFC V5 1/9] hw/intc: Implement GIC-500 support files List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: 'Shlomo Pongratz' Cc: peter.maydell@linaro.org, eric.auger@linaro.org, 'Shlomo Pongratz' , qemu-devel@nongnu.org, shannon.zhao@linaro.org, ashoks@broadcom.com, imammedo@redhat.com Hello! > I can't find the patch that handles the for example modification of = "uint8_t sgi_pending[GIC_NR_SGIS][GIC_NCPU]" to fixed-size bitmaps. as > GIC_NCPU is not a constant and uint8_t need to have the size of nubmer = of CPUs which is no longer bounded. This is the only thing which i excluded, because my vGIC implementation = didn't need these flags. I know that you cannot actually omit them in = software emulation, because they are needed in order to handle a = situation where more than one CPU sends the same SGI number. I think you can place it in distributor, in "internal state" section, = if you look at my patch. > Are you sure that the semantics is the same? In section 4.1.4 of GICv3 = I see that the security level is a combination of two registers GRPMOD > = and GROUP and I wanted to be prepared for it. Looks like you have some private NDA version of the manual, because my = one (downloaded from infocenter) doesn't have a paragraph numbered = 4.1.4. Anyway, after reading my one, i think that GRPMOD simply = overrides what is specified in GROUP. I cannot find such thing as "group = 2" anywhere, and all the text starts with "In a GIC which supports two = security states". So, there's only non-secure and secure state, nothing = else. Again, nothing changes since ARM32. > I assume you want to distinguish between Secure EL1 and Secure EL3 (in = the future). As far as i understand, EL3 is what was called "monitor" in ARM32, and = i would still prefer to call it this way, because it is more meaningful = than those stupid (IMHO) numbers. The only special thing about this mode = is that it allows you to freely switch between secure and non-secure = states. So, again, there's nothing special about "secure EL3". Peter, please correct me if i'm wrong. > I don't have access to the internal CPU's data structures in the GIC's = core, its an opaque structure to the GIC. > Including the CPU include files doesn't seems to work. See this: = http://lists.nongnu.org/archive/html/qemu-devel/2015-10/msg02349.html. = This is also a part of my live migration RFC. I remember that Peter told long time ago that "it should really be a = property", when i integrated full affinity support. But, he currently = refused to accept this small standalone patch because there are no users = for now. My GICv3 live migration is waiting for kernel API to be ready. = And kernel API is waiting for kernel 4.5 development cycle to begin. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia