* [Qemu-devel] [PATCH] tests/Makefile: Do not print the name of the check-block.sh shell script
@ 2019-09-06 11:35 Thomas Huth
2019-09-09 16:40 ` John Snow
2019-09-10 10:53 ` Max Reitz
0 siblings, 2 replies; 5+ messages in thread
From: Thomas Huth @ 2019-09-06 11:35 UTC (permalink / raw)
To: qemu-block, Max Reitz; +Cc: Kevin Wolf, qemu-trivial, qemu-devel
The check script is already printing out which iotest is currently
running, so printing out the name of the check-block.sh shell script
looks superfluous here.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/Makefile.include | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/Makefile.include b/tests/Makefile.include
index f5ac09549c..a36317ac87 100644
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
@@ -1097,7 +1097,7 @@ QEMU_IOTESTS_HELPERS-$(call land,$(CONFIG_SOFTMMU),$(CONFIG_LINUX)) = tests/qemu
check-tests/check-block.sh: tests/check-block.sh qemu-img$(EXESUF) \
qemu-io$(EXESUF) qemu-nbd$(EXESUF) $(QEMU_IOTESTS_HELPERS-y) \
$(patsubst %,%/all,$(filter %-softmmu,$(TARGET_DIRS)))
- $<
+ @$<
.PHONY: $(patsubst %, check-%, $(check-qapi-schema-y))
$(patsubst %, check-%, $(check-qapi-schema-y)): check-%.json: $(SRC_PATH)/%.json
--
2.18.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] tests/Makefile: Do not print the name of the check-block.sh shell script
2019-09-06 11:35 [Qemu-devel] [PATCH] tests/Makefile: Do not print the name of the check-block.sh shell script Thomas Huth
@ 2019-09-09 16:40 ` John Snow
2019-09-10 10:53 ` Max Reitz
1 sibling, 0 replies; 5+ messages in thread
From: John Snow @ 2019-09-09 16:40 UTC (permalink / raw)
To: Thomas Huth, qemu-block, Max Reitz; +Cc: Kevin Wolf, qemu-trivial, qemu-devel
On 9/6/19 7:35 AM, Thomas Huth wrote:
> The check script is already printing out which iotest is currently
> running, so printing out the name of the check-block.sh shell script
> looks superfluous here.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Makes sense.
Acked-by: John Snow <jsnow@redhat.com>
> ---
> tests/Makefile.include | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index f5ac09549c..a36317ac87 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -1097,7 +1097,7 @@ QEMU_IOTESTS_HELPERS-$(call land,$(CONFIG_SOFTMMU),$(CONFIG_LINUX)) = tests/qemu
> check-tests/check-block.sh: tests/check-block.sh qemu-img$(EXESUF) \
> qemu-io$(EXESUF) qemu-nbd$(EXESUF) $(QEMU_IOTESTS_HELPERS-y) \
> $(patsubst %,%/all,$(filter %-softmmu,$(TARGET_DIRS)))
> - $<
> + @$<
>
> .PHONY: $(patsubst %, check-%, $(check-qapi-schema-y))
> $(patsubst %, check-%, $(check-qapi-schema-y)): check-%.json: $(SRC_PATH)/%.json
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] tests/Makefile: Do not print the name of the check-block.sh shell script
2019-09-06 11:35 [Qemu-devel] [PATCH] tests/Makefile: Do not print the name of the check-block.sh shell script Thomas Huth
2019-09-09 16:40 ` John Snow
@ 2019-09-10 10:53 ` Max Reitz
2019-09-10 10:55 ` Thomas Huth
1 sibling, 1 reply; 5+ messages in thread
From: Max Reitz @ 2019-09-10 10:53 UTC (permalink / raw)
To: Thomas Huth, qemu-block; +Cc: Kevin Wolf, qemu-trivial, qemu-devel
[-- Attachment #1.1: Type: text/plain, Size: 460 bytes --]
On 06.09.19 13:35, Thomas Huth wrote:
> The check script is already printing out which iotest is currently
> running, so printing out the name of the check-block.sh shell script
> looks superfluous here.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/Makefile.include | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Max Reitz <mreitz@redhat.com>
(Not sure which tree you’d like this to go through...)
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] tests/Makefile: Do not print the name of the check-block.sh shell script
2019-09-10 10:53 ` Max Reitz
@ 2019-09-10 10:55 ` Thomas Huth
2019-09-10 10:57 ` Max Reitz
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Huth @ 2019-09-10 10:55 UTC (permalink / raw)
To: Max Reitz, qemu-block; +Cc: Kevin Wolf, qemu-trivial, qemu-devel
[-- Attachment #1.1: Type: text/plain, Size: 594 bytes --]
On 10/09/2019 12.53, Max Reitz wrote:
> On 06.09.19 13:35, Thomas Huth wrote:
>> The check script is already printing out which iotest is currently
>> running, so printing out the name of the check-block.sh shell script
>> looks superfluous here.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>> tests/Makefile.include | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Max Reitz <mreitz@redhat.com>
>
> (Not sure which tree you’d like this to go through...)
I think either your block tree or trivial would be appropriate?
Thomas
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] tests/Makefile: Do not print the name of the check-block.sh shell script
2019-09-10 10:55 ` Thomas Huth
@ 2019-09-10 10:57 ` Max Reitz
0 siblings, 0 replies; 5+ messages in thread
From: Max Reitz @ 2019-09-10 10:57 UTC (permalink / raw)
To: Thomas Huth, qemu-block; +Cc: Kevin Wolf, qemu-trivial, qemu-devel
[-- Attachment #1.1: Type: text/plain, Size: 679 bytes --]
On 10.09.19 12:55, Thomas Huth wrote:
> On 10/09/2019 12.53, Max Reitz wrote:
>> On 06.09.19 13:35, Thomas Huth wrote:
>>> The check script is already printing out which iotest is currently
>>> running, so printing out the name of the check-block.sh shell script
>>> looks superfluous here.
>>>
>>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>>> ---
>>> tests/Makefile.include | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Reviewed-by: Max Reitz <mreitz@redhat.com>
>>
>> (Not sure which tree you’d like this to go through...)
>
> I think either your block tree or trivial would be appropriate?
OK then, I’ve taken it. :-)
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-09-10 11:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-06 11:35 [Qemu-devel] [PATCH] tests/Makefile: Do not print the name of the check-block.sh shell script Thomas Huth
2019-09-09 16:40 ` John Snow
2019-09-10 10:53 ` Max Reitz
2019-09-10 10:55 ` Thomas Huth
2019-09-10 10:57 ` Max Reitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).