From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41172)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <p.fedin@samsung.com>) id 1ZmhBs-0003sB-K0
	for qemu-devel@nongnu.org; Thu, 15 Oct 2015 07:59:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <p.fedin@samsung.com>) id 1ZmhBp-0006k6-8k
	for qemu-devel@nongnu.org; Thu, 15 Oct 2015 07:59:24 -0400
Received: from mailout2.w1.samsung.com ([210.118.77.12]:38622)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <p.fedin@samsung.com>) id 1ZmhBp-0006jc-2S
	for qemu-devel@nongnu.org; Thu, 15 Oct 2015 07:59:21 -0400
Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245])
	by mailout2.w1.samsung.com
	(Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5
	2014)) with ESMTP id <0NW9001ZIFYRRN20@mailout2.w1.samsung.com> for
	qemu-devel@nongnu.org; Thu, 15 Oct 2015 12:59:15 +0100 (BST)
From: Pavel Fedin <p.fedin@samsung.com>
References: <cover.1444906971.git.p.fedin@samsung.com>
	<563ff802708c96d128f2d0dda662433044c987ea.1444906971.git.p.fedin@samsung.com>
	<20151015134115.0a7b0b74.cornelia.huck@de.ibm.com>
In-reply-to: <20151015134115.0a7b0b74.cornelia.huck@de.ibm.com>
Date: Thu, 15 Oct 2015 14:59:13 +0300
Message-id: <00ff01d10740$e9786d20$bc694760$@samsung.com>
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii
Content-transfer-encoding: 7bit
Content-language: ru
Subject: Re: [Qemu-devel] [PATCH v5 3/3] kvm: Pass PCI device pointer to MSI
 routing functions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: 'Cornelia Huck' <cornelia.huck@de.ibm.com>
Cc: 'Peter Maydell' <peter.maydell@linaro.org>, 'Paolo Bonzini' <pbonzini@redhat.com>, qemu-devel@nongnu.org, "'Michael S. Tsirkin'" <mst@redhat.com>

 Hello!

> Should the pci_dev be passed to kvm_arch_fixup_msi_route() as well?
> Currently, the only implementer of this function (s390x) does not need
> it; but it shouldn't hurt?

 Yes, it shouldn't. I didn't pass it there exactly because of this reason. However, &kroute is also passed to this function, so
setting ARM-specific data could be moved there. I mean this repeating sequence (see vITS RFC 4/6 -
https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg07075.html):
--- cut ---
    kroute.flags = kvm_msi_flags;
    if (kroute.flags & KVM_MSI_VALID_DEVID) {
        kroute.u.msi.devid = pci_requester_id(dev);
    }
--- cut ---

Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia