From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 371B0C43461 for ; Thu, 10 Sep 2020 15:33:19 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B23B62087C for ; Thu, 10 Sep 2020 15:33:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="d+bWXZ0c" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B23B62087C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58694 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kGOZZ-00011w-Qd for qemu-devel@archiver.kernel.org; Thu, 10 Sep 2020 11:33:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42390) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kGOXS-00072h-9C for qemu-devel@nongnu.org; Thu, 10 Sep 2020 11:31:06 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:59641 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kGOXL-0000gr-KG for qemu-devel@nongnu.org; Thu, 10 Sep 2020 11:31:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1599751857; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=msB3iRXK78wsjGGKQ/jnE1f2F0dBJKmw/dIKpjU/6BA=; b=d+bWXZ0cacfr84ufqz9Q38Kwf3fzZDRZnrGM7RrMQyYLp3m+fPBBgVt7YviJzndVuxh4yC uAVhWphpkUcw9v9ELIG0cEaWRvmkN6JPCNi4G7HCxRxhmQlJgykEK8++qf4xYjOpUXFGqu z9EhnMNTSngaAhaC7h5PMJ2yoVc3Cdg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-189-4KTmbn0wOnCncSLLRnst-g-1; Thu, 10 Sep 2020 11:30:55 -0400 X-MC-Unique: 4KTmbn0wOnCncSLLRnst-g-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F0FB1107F21C; Thu, 10 Sep 2020 15:30:53 +0000 (UTC) Received: from dresden.str.redhat.com (ovpn-112-197.ams2.redhat.com [10.36.112.197]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 05B947E8F9; Thu, 10 Sep 2020 15:30:52 +0000 (UTC) Subject: Re: [PATCH 26/29] nbd: Merge nbd_export_new() and nbd_export_create() To: Kevin Wolf , qemu-block@nongnu.org References: <20200907182011.521007-1-kwolf@redhat.com> <20200907182011.521007-27-kwolf@redhat.com> From: Max Reitz Autocrypt: addr=mreitz@redhat.com; prefer-encrypt=mutual; keydata= mQENBFXOJlcBCADEyyhOTsoa/2ujoTRAJj4MKA21dkxxELVj3cuILpLTmtachWj7QW+TVG8U /PsMCFbpwsQR7oEy8eHHZwuGQsNpEtNC2G/L8Yka0BIBzv7dEgrPzIu+W3anZXQW4702+uES U29G8TP/NGfXRRHGlbBIH9KNUnOSUD2vRtpOLXkWsV5CN6vQFYgQfFvmp5ZpPeUe6xNplu8V mcTw8OSEDW/ZnxJc8TekCKZSpdzYoxfzjm7xGmZqB18VFwgJZlIibt1HE0EB4w5GsD7x5ekh awIe3RwoZgZDLQMdOitJ1tUc8aqaxvgA4tz6J6st8D8pS//m1gAoYJWGwwIVj1DjTYLtABEB AAG0HU1heCBSZWl0eiA8bXJlaXR6QHJlZGhhdC5jb20+iQFTBBMBCAA9AhsDBQkSzAMABQsJ CAcCBhUICQoLAgQWAgMBAh4BAheABQJVzie5FRhoa3A6Ly9rZXlzLmdudXBnLm5ldAAKCRD0 B9sAYdXPQDcIB/9uNkbYEex1rHKz3mr12uxYMwLOOFY9fstP5aoVJQ1nWQVB6m2cfKGdcRe1 2/nFaHSNAzT0NnKz2MjhZVmcrpyd2Gp2QyISCfb1FbT82GMtXFj1wiHmPb3CixYmWGQUUh+I AvUqsevLA+WihgBUyaJq/vuDVM1/K9Un+w+Tz5vpeMidlIsTYhcsMhn0L9wlCjoucljvbDy/ 8C9L2DUdgi3XTa0ORKeflUhdL4gucWoAMrKX2nmPjBMKLgU7WLBc8AtV+84b9OWFML6NEyo4 4cP7cM/07VlJK53pqNg5cHtnWwjHcbpGkQvx6RUx6F1My3y52vM24rNUA3+ligVEgPYBuQEN BFXOJlcBCADAmcVUNTWT6yLWQHvxZ0o47KCP8OcLqD+67T0RCe6d0LP8GsWtrJdeDIQk+T+F xO7DolQPS6iQ6Ak2/lJaPX8L0BkEAiMuLCKFU6Bn3lFOkrQeKp3u05wCSV1iKnhg0UPji9V2 W5eNfy8F4ZQHpeGUGy+liGXlxqkeRVhLyevUqfU0WgNqAJpfhHSGpBgihUupmyUg7lfUPeRM DzAN1pIqoFuxnN+BRHdAecpsLcbR8sQddXmDg9BpSKozO/JyBmaS1RlquI8HERQoe6EynJhd 64aICHDfj61rp+/0jTIcevxIIAzW70IadoS/y3DVIkuhncgDBvGbF3aBtjrJVP+5ABEBAAGJ ASUEGAEIAA8FAlXOJlcCGwwFCRLMAwAACgkQ9AfbAGHVz0CbFwf9F/PXxQR9i4N0iipISYjU sxVdjJOM2TMut+ZZcQ6NSMvhZ0ogQxJ+iEQ5OjnIputKvPVd5U7WRh+4lF1lB/NQGrGZQ1ic alkj6ocscQyFwfib+xIe9w8TG1CVGkII7+TbS5pXHRxZH1niaRpoi/hYtgzkuOPp35jJyqT/ /ELbqQTDAWcqtJhzxKLE/ugcOMK520dJDeb6x2xVES+S5LXby0D4juZlvUj+1fwZu+7Io5+B bkhSVPb/QdOVTpnz7zWNyNw+OONo1aBUKkhq2UIByYXgORPFnbfMY7QWHcjpBVw9MgC4tGeF R4bv+1nAMMxKmb5VvQCExr0eFhJUAHAhVg== Message-ID: <01011d49-fbfe-d21d-41ff-d23b50ad6a2d@redhat.com> Date: Thu, 10 Sep 2020 17:30:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200907182011.521007-27-kwolf@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mreitz@redhat.com X-Mimecast-Spam-Score: 0.0 X-Mimecast-Originator: redhat.com Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="N0LufVzapyRNHaqhXFPhzAtDBtkooi2aJ" Received-SPF: pass client-ip=207.211.31.120; envelope-from=mreitz@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/10 08:35:50 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -56 X-Spam_score: -5.7 X-Spam_bar: ----- X-Spam_report: (-5.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-3.576, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --N0LufVzapyRNHaqhXFPhzAtDBtkooi2aJ Content-Type: multipart/mixed; boundary="5Mrc05Ss6QqgxJ4vetemdRg8bqiUHECPX" --5Mrc05Ss6QqgxJ4vetemdRg8bqiUHECPX Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 07.09.20 20:20, Kevin Wolf wrote: > There is no real reason any more why nbd_export_new() and > nbd_export_create() should be separate functions. The latter only > performs a few checks before it calls the former. Move all the checks to > nbd/server.c and make the resulting function static. >=20 > Signed-off-by: Kevin Wolf > --- > include/block/nbd.h | 7 +----- > blockdev-nbd.c | 40 +++++---------------------------- > nbd/server.c | 54 ++++++++++++++++++++++++++++++++------------- > 3 files changed, 45 insertions(+), 56 deletions(-) I suppose it=E2=80=99s a question of style whether one big function (120 lo= c is quite big) is better than two functions chain-calling each other (with a poor split of functionality between the two). I wouldn=E2=80=99t have anything against clearly splitting the functionalit= y into a function that checks the parameters, and another one that actually creates the export. In any case this isn=E2=80=99t the first function in qemu with more than 10= 0 loc and it won=E2=80=99t be the last; and it allows getting rid of two public functions, so: Reviewed-by: Max Reitz --5Mrc05Ss6QqgxJ4vetemdRg8bqiUHECPX-- --N0LufVzapyRNHaqhXFPhzAtDBtkooi2aJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEkb62CjDbPohX0Rgp9AfbAGHVz0AFAl9aRqsACgkQ9AfbAGHV z0ApFwf/X9gkixayajyg92WHQlA67qD+2wuvPz+HGz3lT7n6X88YQtD8647QxA5B /HQ6d2AqXK/oufXJsW4gtauHjv/EbjemsmoOWDdxq8bIZOcKhDBhzwfU6zuPdNlp PjnnBYs67HlOKlJsJfCVRgdftG+uQdJdWHhMkOOmEBGueLl0onGYg/vPEEOYp1WW qLTyDsDeNYKWnSxz5bkSbzXP1fu8axZvg/VrMjW49MWpxvgrUKtNqFEOPm7bfskT DNkiaepn2PCU/IwxQrJVhKn1m6RpPOBZK03tVGhptUAxRxxX5+dRc7atl1PsiPYq ligChtpozD5VHwhK9mNoVud8mf4jqA== =iyh4 -----END PGP SIGNATURE----- --N0LufVzapyRNHaqhXFPhzAtDBtkooi2aJ--