From: Max Reitz <mreitz@redhat.com>
To: Stefano Garzarella <sgarzare@redhat.com>, Yi Li <yili@winhong.com>
Cc: kwolf@redhat.com, yilikernel@gmail.com, qemu-devel@nongnu.org,
qemu-block@nongnu.org
Subject: Re: [PATCH] qemu-img: Explicit number replaced by a constant
Date: Tue, 18 Aug 2020 13:51:23 +0200 [thread overview]
Message-ID: <0107e40a-1d96-fa3d-bd15-019c004d0353@redhat.com> (raw)
In-Reply-To: <20200818071918.vzdhdlndxuviq3ue@steredhat>
[-- Attachment #1.1: Type: text/plain, Size: 873 bytes --]
On 18.08.20 09:19, Stefano Garzarella wrote:
> Hi Yi Li,
> thanks for this patch! Just a comment below:
>
> On Mon, Aug 17, 2020 at 07:01:13PM +0800, Yi Li wrote:
>> Signed-off-by: Yi Li <yili@winhong.com>
>> ---
>> qemu-img.c | 12 ++++++------
>> 1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/qemu-img.c b/qemu-img.c
>> index 5308773811..a0fbc2757c 100644
>> --- a/qemu-img.c
>> +++ b/qemu-img.c
>> @@ -1181,7 +1181,7 @@ static int64_t find_nonzero(const uint8_t *buf, int64_t n)
>> }
>>
>> /*
>> - * Returns true iff the first sector pointed to by 'buf' contains at least
>> + * Returns true if the first sector pointed to by 'buf' contains at least
>
> This change seems unrelated, please can you put this in a separate patch?
It’s also just not a correct change, as “iff” means “if and only if”.
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-08-18 11:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 11:01 [PATCH] qemu-img: Explicit number replaced by a constant Yi Li
2020-08-18 7:19 ` Stefano Garzarella
2020-08-18 11:51 ` Max Reitz [this message]
2020-08-19 1:36 ` [PATCH v2] " Yi Li
2020-08-19 8:48 ` Alberto Garcia
2020-08-19 8:57 ` Stefano Garzarella
2020-09-07 9:08 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0107e40a-1d96-fa3d-bd15-019c004d0353@redhat.com \
--to=mreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sgarzare@redhat.com \
--cc=yili@winhong.com \
--cc=yilikernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).