From: Thomas Huth <thuth@redhat.com>
To: "Jamin Lin" <jamin_lin@aspeedtech.com>,
"Cédric Le Goater" <clg@kaod.org>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Steven Lee" <steven_lee@aspeedtech.com>,
"Troy Lee" <leetroy@gmail.com>,
"Andrew Jeffery" <andrew@codeconstruct.com.au>,
"Joel Stanley" <joel@jms.id.au>,
"Alistair Francis" <alistair@alistair23.me>,
"Kevin Wolf" <kwolf@redhat.com>,
"Hanna Reitz" <hreitz@redhat.com>,
"Laurent Vivier" <lvivier@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"open list:ASPEED BMCs" <qemu-arm@nongnu.org>,
"open list:All patches CC here" <qemu-devel@nongnu.org>,
"open list:Block layer core" <qemu-block@nongnu.org>,
"Fabiano Rosas" <farosas@suse.de>
Cc: troy_lee@aspeedtech.com, yunlin.tang@aspeedtech.com
Subject: Re: [PATCH v1 07/16] test/qtest/aspeed_smc-test: Fix coding style
Date: Fri, 18 Oct 2024 10:25:33 +0200 [thread overview]
Message-ID: <011d3d75-2bf0-44eb-ba78-bf92240128f8@redhat.com> (raw)
In-Reply-To: <20241018053112.1886173-8-jamin_lin@aspeedtech.com>
On 18/10/2024 07.31, Jamin Lin wrote:
> Fix coding style issues from checkpatch.pl
>
> Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
> ---
> tests/qtest/aspeed_smc-test.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/tests/qtest/aspeed_smc-test.c b/tests/qtest/aspeed_smc-test.c
> index c713a3700b..4673371d95 100644
> --- a/tests/qtest/aspeed_smc-test.c
> +++ b/tests/qtest/aspeed_smc-test.c
> @@ -353,7 +353,8 @@ static void test_read_page_mem(void)
> uint32_t page[FLASH_PAGE_SIZE / 4];
> int i;
>
> - /* Enable 4BYTE mode for controller. This is should be strapped by
> + /*
> + * Enable 4BYTE mode for controller. This is should be strapped by
> * HW for CE0 anyhow.
> */
> spi_ce_ctrl(1 << CRTL_EXTENDED0);
> @@ -394,7 +395,8 @@ static void test_write_page_mem(void)
> uint32_t page[FLASH_PAGE_SIZE / 4];
> int i;
>
> - /* Enable 4BYTE mode for controller. This is should be strapped by
> + /*
> + * Enable 4BYTE mode for controller. This is should be strapped by
> * HW for CE0 anyhow.
> */
> spi_ce_ctrl(1 << CRTL_EXTENDED0);
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2024-10-18 8:26 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-18 5:30 [PATCH v1 00/16] Fix write incorrect data into flash in user mode Jamin Lin via
2024-10-18 5:30 ` [PATCH v1 01/16] aspeed/smc: " Jamin Lin via
2024-10-22 5:51 ` [SPAM] " Cédric Le Goater
2024-10-22 9:29 ` Jamin Lin
2024-10-18 5:30 ` [PATCH v1 02/16] hw/block:m25p80: Fix coding style Jamin Lin via
2024-10-18 13:31 ` [SPAM] " Cédric Le Goater
2024-10-18 5:30 ` [PATCH v1 03/16] hw/block:m25p80: Support write status register 2 command (0x31) for w25q01jvq Jamin Lin via
2024-10-21 8:53 ` [SPAM] " Cédric Le Goater
2024-10-18 5:31 ` [PATCH v1 04/16] hw/block/m25p80: Add SFDP table for w25q80bl flash Jamin Lin via
2024-10-21 9:05 ` [SPAM] " Cédric Le Goater
2024-10-18 5:31 ` [PATCH v1 05/16] hw/arm/aspeed: Correct spi_model w25q256 for ast1030-a1 EVB Jamin Lin via
2024-10-21 9:06 ` [SPAM] " Cédric Le Goater
2024-10-18 5:31 ` [PATCH v1 06/16] hw/arm/aspeed: Correct fmc_model w25q80bl " Jamin Lin via
2024-10-21 9:07 ` [SPAM] " Cédric Le Goater
2024-10-18 5:31 ` [PATCH v1 07/16] test/qtest/aspeed_smc-test: Fix coding style Jamin Lin via
2024-10-18 8:25 ` Thomas Huth [this message]
2024-10-21 12:02 ` [SPAM] " Cédric Le Goater
2024-10-18 5:31 ` [PATCH v1 08/16] test/qtest/aspeed_smc-test: Move testcases to test_palmetto_bmc function Jamin Lin via
2024-10-21 12:02 ` [SPAM] " Cédric Le Goater
2024-10-18 5:31 ` [PATCH v1 09/16] test/qtest/aspeed_smc-test: Introduce a new TestData to test different BMC SOCs Jamin Lin via
2024-10-21 12:13 ` [SPAM] " Cédric Le Goater
2024-10-22 1:38 ` Jamin Lin
2024-10-22 5:54 ` Cédric Le Goater
2024-10-18 5:31 ` [PATCH v1 10/16] test/qtest/aspeed_smc-test: Support to test all CE pins Jamin Lin via
2024-10-21 12:33 ` [SPAM] " Cédric Le Goater
2024-10-18 5:31 ` [PATCH v1 11/16] test/qtest/aspeed_smc-test: Support to test all flash models Jamin Lin via
2024-10-21 12:39 ` [SPAM] " Cédric Le Goater
2024-10-21 23:34 ` Andrew Jeffery
2024-10-22 1:45 ` Jamin Lin
2024-10-22 1:40 ` Jamin Lin
2024-10-18 5:31 ` [PATCH v1 12/16] test/qtest/aspeed_smc-test: Support to test AST2500 Jamin Lin via
2024-10-21 12:47 ` [SPAM] " Cédric Le Goater
2024-10-18 5:31 ` [PATCH v1 13/16] test/qtest/aspeed_smc-test: Support to test AST2600 Jamin Lin via
2024-10-21 12:47 ` [SPAM] " Cédric Le Goater
2024-10-18 5:31 ` [PATCH v1 14/16] test/qtest/aspeed_smc-test: Support to test AST1030 Jamin Lin via
2024-10-21 12:47 ` [SPAM] " Cédric Le Goater
2024-10-18 5:31 ` [PATCH v1 15/16] test/qtest/aspeed_smc-test: Support write page command with QPI mode Jamin Lin via
2024-10-21 12:53 ` [SPAM] " Cédric Le Goater
2024-10-18 5:31 ` [PATCH v1 16/16] test/qtest/ast2700-smc-test: Support to test AST2700 Jamin Lin via
2024-10-21 12:58 ` [SPAM] " Cédric Le Goater
2024-10-22 1:53 ` Jamin Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=011d3d75-2bf0-44eb-ba78-bf92240128f8@redhat.com \
--to=thuth@redhat.com \
--cc=alistair@alistair23.me \
--cc=andrew@codeconstruct.com.au \
--cc=clg@kaod.org \
--cc=farosas@suse.de \
--cc=hreitz@redhat.com \
--cc=jamin_lin@aspeedtech.com \
--cc=joel@jms.id.au \
--cc=kwolf@redhat.com \
--cc=leetroy@gmail.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=steven_lee@aspeedtech.com \
--cc=troy_lee@aspeedtech.com \
--cc=yunlin.tang@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).