From: Jason Wang <jasowang@redhat.com>
To: P J P <ppandit@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Gaoning Pan" <pgn@zju.edu.cn>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"QEMU Developers" <qemu-devel@nongnu.org>
Subject: Re: [PATCH v3] net: remove an assert call in eth_get_gso_type
Date: Mon, 26 Oct 2020 11:30:12 +0800 [thread overview]
Message-ID: <012c023d-9351-1bfc-1c1b-77b47a54434e@redhat.com> (raw)
In-Reply-To: <nycvar.YSQ.7.78.906.2010211440290.1506567@xnncv>
On 2020/10/21 下午5:23, P J P wrote:
> +-- On Wed, 21 Oct 2020, Jason Wang wrote --+
> | It should not be a guest error, since guest is allowed to send a packet
> | other than IPV4(6).
>
> * Ah...sigh! :(
>
> * I very hesitantly used guest_error mask, since it was g_assert-ing before.
> To me both guest_error and log_unimp seem mismatching. Because no GSO is
> also valid IIUC. That's why in patch v2 I used plain qemu_log(). But plain
> qemu_log is also not good it seems.
>
> * I'm okay either way. Please let me know which one to use. OR I'm fine if you
> fix it while merging upstream too.
I see.
I applied the patch as is.
Thanks
>
>
> Thank you.
> --
> Prasad J Pandit / Red Hat Product Security Team
> 8685 545E B54C 486B C6EB 271E E285 8B5A F050 DE8D
>
>
next prev parent reply other threads:[~2020-10-26 3:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-21 6:05 [PATCH v3] net: remove an assert call in eth_get_gso_type P J P
2020-10-21 7:44 ` Jason Wang
2020-10-21 9:23 ` P J P
2020-10-26 3:30 ` Jason Wang [this message]
2020-10-26 9:59 ` Peter Maydell
2020-10-28 2:25 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=012c023d-9351-1bfc-1c1b-77b47a54434e@redhat.com \
--to=jasowang@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=pgn@zju.edu.cn \
--cc=philmd@redhat.com \
--cc=ppandit@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).