From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53917) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXlOA-0004jr-NN for qemu-devel@nongnu.org; Fri, 04 Sep 2015 03:26:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZXlO7-0002qS-Gr for qemu-devel@nongnu.org; Fri, 04 Sep 2015 03:26:22 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:36537) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXlO7-0002pr-Bu for qemu-devel@nongnu.org; Fri, 04 Sep 2015 03:26:19 -0400 Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout2.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NU5008M65ZSB820@mailout2.w1.samsung.com> for qemu-devel@nongnu.org; Fri, 04 Sep 2015 08:26:16 +0100 (BST) From: Pavel Fedin References: <01123b8a3d47648ef362909967f22c7dab0cfd71.1440584396.git.p.fedin@samsung.com> In-reply-to: Date: Fri, 04 Sep 2015 10:26:14 +0300 Message-id: <013401d0e6e2$fbf4dbb0$f3de9310$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: quoted-printable Content-language: ru Subject: Re: [Qemu-devel] [PATCH v12 5/5] hw/arm/virt: Add gic-version option to virt machine List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: 'Peter Maydell' Cc: 'Shlomo Pongratz' , 'Shlomo Pongratz' , 'QEMU Developers' , 'Eric Auger' Hello! > Why have separate ITS_CONTROL and ITS_TRANSLATION entries, given > that the ITS pages are architecturally required to be contiguous > and the dt binding doesn't require you to specify the two addresses > separately? It is more convenient for ITS implementation. I already have the code = for it, and for ITS device it is useful to have two separate sysbus-mmio = regions, one for control and one for translation. Because control area = is fed to KVM and translation area is handled by qemu in userspace, = because it has to catch writes and inject them as KVM_SIGNAL_MSI = ioctl's. So, i have to map two regions, therefore i need two bases. = Sizes are just added together when i create DT binding. Well, i could do the opposite, store them as a single region in memory = map, and just add the appropriate offset when mapping the second = sysbus-mmio region. It's the same amount of arithmetic, actually. What = would you prefer? Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia