From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B25C2C433E2 for ; Fri, 28 Aug 2020 17:00:39 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 791B820776 for ; Fri, 28 Aug 2020 17:00:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="jQR+QMSf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 791B820776 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55074 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kBhjy-0001yz-Lo for qemu-devel@archiver.kernel.org; Fri, 28 Aug 2020 13:00:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34810) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBhis-0001RK-JO for qemu-devel@nongnu.org; Fri, 28 Aug 2020 12:59:30 -0400 Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]:36320) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kBhiq-00028m-S0 for qemu-devel@nongnu.org; Fri, 28 Aug 2020 12:59:30 -0400 Received: by mail-pl1-x643.google.com with SMTP id y6so780323plt.3 for ; Fri, 28 Aug 2020 09:59:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=KPZsSQvXc1iyhQ4OI19z388LQtAJQ5cTeGI4HV7TyOg=; b=jQR+QMSfTXjYuw1bprcZKJZkDWHhKf0tPNF9xfOQmhvcl9i5Isrcq9G9GTjj8c4tb+ vLmXHWD6H9E5zGMSQuYHNgild8TnYu02jtwO/qhtIYKhFvCcDdBdH0+oCoUk0GjUbjOr UvDffsvyn4Sc8QDZGlvvRTxFEjT0/se5/GfC9FyiQiAVwQlYnadNblrIzTRNkALeZsL/ +rMBdr+80VhCH/VB/1YvcC8IxSnCWve0tMOMq8cyEuZHFDYA3oKyS1B7XMkh+I+2QsVZ sLbXeqypmujwN87f8wPKuzRRXzDL+6dVVO7TOnaClBd2JanSC5qM5kGKnJfRDEq/DB4n IWaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=KPZsSQvXc1iyhQ4OI19z388LQtAJQ5cTeGI4HV7TyOg=; b=k/VFLZEHeS8cuEvGqIlmgMwukawqQP9nJ5Smu3inMFF3JEVu+QTDPHGartmPej9W+d hgqTYIglAPfiKsrHf7caSZvCtjfvAjTkiHwILPrGX0ZGy63hp1WS4CWdxTey9N2K2TB/ gNbHrA3rT6A5hQLwONWNTVZMux3YiLPvcfaw+ndYS1uoZrCrjTSheTtw2zDEOHTHzkRV ZW2XLTB+ZRajBUANW+wnG5t2hQ3HY9AuKX5EcbdpP3SuFkMUqrQsQZlv6lOKf3LMtqXU sjwR7k+FK3HgBogLfv+yi5EuRP+U6tZOsNQ2cX40nqzgYd4dM3XwzHHLd0X2ofN4A6JT cBCA== X-Gm-Message-State: AOAM531PFVc8O94R2xEfI2Rd052aX1nNYXu3+cETW0YzjN8jp2jWz/Gy erES9SMCXUGZ+0UGax9idF6iSA== X-Google-Smtp-Source: ABdhPJzqDxfXeIaWzWpN3P5m2bG0TniYAwjHvN5LAzxkpt1oR5gT8T72g6tHxDCnSvVpQcX0qNQTAA== X-Received: by 2002:a17:902:44f:: with SMTP id 73mr2104211ple.178.1598633967319; Fri, 28 Aug 2020 09:59:27 -0700 (PDT) Received: from [192.168.1.11] ([71.212.141.89]) by smtp.gmail.com with ESMTPSA id a69sm2331385pfa.116.2020.08.28.09.59.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Aug 2020 09:59:26 -0700 (PDT) Subject: Re: [PATCH 1/2] crypto: fix build without gcrypt and gnutls To: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= References: <20200828132716.279782-1-berrange@redhat.com> <20200828132716.279782-2-berrange@redhat.com> <0a1a8958-691f-d16d-2f6b-6392e6a20966@linaro.org> <20200828152318.GO224144@redhat.com> From: Richard Henderson Message-ID: <013504f4-e962-bcdd-edc6-f225d4db87a4@linaro.org> Date: Fri, 28 Aug 2020 09:59:24 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200828152318.GO224144@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::643; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x643.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.809, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Thomas Huth , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org, Wainer dos Santos Moschetta , Paolo Bonzini , =?UTF-8?Q?Alex_Benn=c3=a9e?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 8/28/20 8:23 AM, Daniel P. Berrangé wrote: > On Fri, Aug 28, 2020 at 08:13:26AM -0700, Richard Henderson wrote: >> On 8/28/20 6:27 AM, Daniel P. Berrangé wrote: >>> If nettle is disabled and gcrypt enabled, the compiler and linker flags >>> needed for gcrypt are not passed. >>> >>> Gnutls was also not added as a dependancy wen gcrypt is enabled. >>> >>> Signed-off-by: Daniel P. Berrangé >> >> This still needs something else. I get >> >> Linking target qemu-x86_64 >> /usr/bin/ld: libqemuutil.a(crypto_init.c.o): in function `qcrypto_init': >> /home/rth/qemu/bld-g/../qemu/crypto/init.c:111: undefined reference to >> `gnutls_global_init' >> /usr/bin/ld: /home/rth/qemu/bld-g/../qemu/crypto/init.c:113: undefined >> reference to `gnutls_strerror' >> collect2: error: ld returned 1 exit status >> make: *** [Makefile.ninja:1570: qemu-x86_64] Error 1 > > Can you tell me what configure args you're using and host OS distro ../qemu/configure --enable-gcrypt \ --target-list=x86_64-softmmu,x86_64-linux-user On ubuntu 20 (focal). r~