From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BC9C8CE8D46 for ; Thu, 19 Sep 2024 04:33:55 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sr8qi-0001Xr-QH; Thu, 19 Sep 2024 00:33:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sr8qg-0001W8-AO; Thu, 19 Sep 2024 00:32:58 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sr8qe-0005ib-GT; Thu, 19 Sep 2024 00:32:58 -0400 Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 48J06gWb032764; Thu, 19 Sep 2024 04:32:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s=pp1; bh=/ /yJ0NNspX/NjhT+l80KXGos5UAotpfB9myc1LXLROk=; b=HDoLNTgG01OosqJKz 6DUtJdmgAWyktND2QrB0Ptwy8xND0s0NZJ1BCElEJFkdrF9x0/Qk5drOIqwo4REU aEwnyGXj2BzmV+B2ZKmYI3GMweRy2H1yj+bmgcr2i+BiJWZ77Rwrl1/y/ISwUGAR W0HDPb/L3qQveTquKHxHV6peweue8OME8t1RJlr1IYk8cfa9T6mTRhbDPJsK9Bhn DW3YHPSQbaRB8BU+OognT/EGLa7DYcrjClhmEY/stNUf4ZGyoMEay0iLWQ50Sssk wx4Llm0jj8WotdnTj5h/4lXQiO/Fg+Wa4seRBcHZiXAbJTglF8f2R44IZe7zc8P0 D55sw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 41pht8sm1n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 19 Sep 2024 04:32:40 +0000 (GMT) Received: from m0353725.ppops.net (m0353725.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 48J4Wdbx026638; Thu, 19 Sep 2024 04:32:40 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 41pht8sm1f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 19 Sep 2024 04:32:39 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 48J4Ikdj030649; Thu, 19 Sep 2024 04:32:39 GMT Received: from smtprelay04.dal12v.mail.ibm.com ([172.16.1.6]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 41npanf2un-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 19 Sep 2024 04:32:39 +0000 Received: from smtpav06.dal12v.mail.ibm.com (smtpav06.dal12v.mail.ibm.com [10.241.53.105]) by smtprelay04.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 48J4WbB341943300 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 19 Sep 2024 04:32:37 GMT Received: from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BE9715805E; Thu, 19 Sep 2024 04:32:37 +0000 (GMT) Received: from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A953E58059; Thu, 19 Sep 2024 04:32:32 +0000 (GMT) Received: from [9.109.242.165] (unknown [9.109.242.165]) by smtpav06.dal12v.mail.ibm.com (Postfix) with ESMTP; Thu, 19 Sep 2024 04:32:32 +0000 (GMT) Message-ID: <013649bd-4fa2-4a8f-a1a6-c466e14cb787@linux.ibm.com> Date: Thu, 19 Sep 2024 10:02:27 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v16 02/13] hw/ppc/spapr_pci: Do not create DT for disabled PCI device To: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= , Akihiko Odaki , =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , "Michael S. Tsirkin" , Marcel Apfelbaum , Alex Williamson , Paolo Bonzini , =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , Eduardo Habkost , Sriram Yagnaraman , Jason Wang , Keith Busch , Klaus Jensen , Markus Armbruster , Matthew Rosato , Eric Farman , Shivaprasad G Bhat Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org References: <20240913-reuse-v16-0-d016b4b4f616@daynix.com> <20240913-reuse-v16-2-d016b4b4f616@daynix.com> Content-Language: en-US From: Harsh Prateek Bora In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: sFSxDv2kaXYYB2Ii4jyFCCd9Z0KwAPRb X-Proofpoint-ORIG-GUID: gYjhne8AV71192j6B1ocQq16ZtcseQ7l X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-19_02,2024-09-18_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 phishscore=0 bulkscore=0 suspectscore=0 priorityscore=1501 adultscore=0 mlxlogscore=999 mlxscore=0 clxscore=1011 malwarescore=0 spamscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2408220000 definitions=main-2409190025 Received-SPF: pass client-ip=148.163.158.5; envelope-from=harshpb@linux.ibm.com; helo=mx0b-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 9/18/24 19:57, Cédric Le Goater wrote: > Hello, > > Adding : > >   Harsh for QEMU/PPC pseries machine, >   Shivaprasad for KVM/PPC VFIO and IOMMU support. > > Could you please give us your feedback on these changes ? > > Thanks, > > C. > > > >  On 9/13/24 05:44, Akihiko Odaki wrote: >> Disabled means it is a disabled SR-IOV VF or it is powered off, and >> hidden from the guest. >> >> Signed-off-by: Akihiko Odaki >> --- >>   hw/ppc/spapr_pci.c | 4 ++++ >>   1 file changed, 4 insertions(+) >> >> diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c >> index 7cf9904c3546..f63182a03c41 100644 >> --- a/hw/ppc/spapr_pci.c >> +++ b/hw/ppc/spapr_pci.c >> @@ -1296,6 +1296,10 @@ static void spapr_dt_pci_device_cb(PCIBus *bus, >> PCIDevice *pdev, >>           return; >>       } >> +    if (!pdev->enabled) { >> +        return; >> +    } >> + While I will let Shivaprasad comment from IO perspective, I would like to suggest merging this condition with the error condition check preceding it. regards, Harsh >>       err = spapr_dt_pci_device(p->sphb, pdev, p->fdt, p->offset); >>       if (err < 0) { >>           p->err = err; >> > >