From: Pavel Fedin <p.fedin@samsung.com>
To: 'Peter Maydell' <peter.maydell@linaro.org>
Cc: 'Shlomo Pongratz' <shlomo.pongratz@huawei.com>,
'Shlomo Pongratz' <shlomopongratz@gmail.com>,
'QEMU Developers' <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] target-arm: Extract some external ARM CPU API
Date: Fri, 23 Oct 2015 18:01:12 +0300 [thread overview]
Message-ID: <013801d10da3$a89ac280$f9d04780$@samsung.com> (raw)
In-Reply-To: <CAFEAcA-gcSAVR1-UM84bT2eqSzrtBM7bopjEuLQb93=QqtwzRw@mail.gmail.com>
Hello!
> Please don't do two things in one patch. (I actually read this patch
> code-first and thought you'd accidentally inserted this change due
> to a rebasing mishap...) It's particularly bad in patches which are
> otherwise almost entirely moving code from one file to another,
> because it's easy to overlook the substantive change in the resulting
> large patch.
Ok, ok, sorry... I really wanted to push this in somehow, and i thought that maybe you'll like it as a little thing that completes the reusable API.
Should i post v2 with this hunk removed?
> > +typedef struct ARMCPUClass {
> > + /*< private >*/
> > + CPUClass parent_class;
> > + /*< public >*/
> > +
> > + DeviceRealize parent_realize;
> > + void (*parent_reset)(CPUState *cpu);
> > +} ARMCPUClass;
>
> I'm slightly surprised we need to define the ARMCPUClass struct
> here -- what needs the definition rather than just the typedef,
> or is this just to follow other header files?
Other header files, i believe, do it for a reason. To tell the truth i made the patch very quickly, and didn't have much time to dig in OBJECT_CLASS_CHECK() internals. Does it need a sizeof() maybe? And without it thing looked a bit ugly and incomplete.
Class structure is pretty self-sufficient and straightforward, so i just moved it too.
I'll reply to the rest of messages on monday, weekend is coming. :)
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
next prev parent reply other threads:[~2015-10-23 15:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-22 13:09 [Qemu-devel] [PATCH] target-arm: Extract some external ARM CPU API Pavel Fedin
2015-10-23 13:57 ` Peter Maydell
2015-10-23 15:01 ` Pavel Fedin [this message]
2015-10-23 15:03 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='013801d10da3$a89ac280$f9d04780$@samsung.com' \
--to=p.fedin@samsung.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=shlomo.pongratz@huawei.com \
--cc=shlomopongratz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).