From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org,
gustavo.romero@linaro.org, qemu-stable@nongnu.org
Subject: Re: [PATCH v2 2/6] target/arm: Fix nregs computation in do_ld_zpa
Date: Wed, 7 Feb 2024 10:42:07 +1000 [thread overview]
Message-ID: <013d6bb4-1021-4c33-8b03-dc01a62d8c03@linaro.org> (raw)
In-Reply-To: <CAFEAcA-ZNwm=OJ6u+e57kyRFnjyR+Br=ZCbOodbQwBZzrjVnhA@mail.gmail.com>
On 2/7/24 00:46, Peter Maydell wrote:
>> @@ -4600,7 +4601,7 @@ static void do_ld_zpa(DisasContext *s, int zt, int pg,
>> * accessible via the instruction encoding.
>> */
>> assert(fn != NULL);
>> - do_mem_zpa(s, zt, pg, addr, dtype, nreg, false, fn);
>> + do_mem_zpa(s, zt, pg, addr, dtype, nreg + 1, false, fn);
>> }
>>
>> static bool trans_LD_zprr(DisasContext *s, arg_rprr_load *a)
>
> What about do_st_zpa() ? It's not obvious what the 'nreg'
> encoding is in the a->nreg field in arg_rprr_store, but
> it's definitely confusing that do_st_zpa() calls
> do_mem_zpa() passing "nreg" whereas do_ld_zpa() now
> passes it "nreg + 1". Can we make it so the handling
> in these two functions lines up?
Yes, I think there may be a bug in store as well.
Comparing the two is complicated by the cut outs for LDFF1, LDNF1, LD1R and PRF.
r~
next prev parent reply other threads:[~2024-02-07 0:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 3:05 [PATCH v2 0/6] target/arm: assorted mte fixes Richard Henderson
2024-02-06 3:05 ` [PATCH v2 1/6] linux-user/aarch64: Extend PR_SET_TAGGED_ADDR_CTRL for FEAT_MTE3 Richard Henderson
2024-02-06 14:23 ` Peter Maydell
2024-02-07 0:31 ` Richard Henderson
2024-02-07 2:10 ` Richard Henderson
2024-02-06 15:18 ` Gustavo Romero
2024-02-06 3:05 ` [PATCH v2 2/6] target/arm: Fix nregs computation in do_ld_zpa Richard Henderson
2024-02-06 14:46 ` Peter Maydell
2024-02-07 0:42 ` Richard Henderson [this message]
2024-02-06 3:05 ` [PATCH v2 3/6] target/arm: Adjust and validate mtedesc sizem1 Richard Henderson
2024-02-06 14:49 ` Peter Maydell
2024-02-06 3:05 ` [PATCH v2 4/6] target/arm: Split out make_svemte_desc Richard Henderson
2024-02-06 14:52 ` Peter Maydell
2024-02-06 3:05 ` [PATCH v2 5/6] target/arm: Handle mte in do_ldrq, do_ldro Richard Henderson
2024-02-06 14:53 ` Peter Maydell
2024-02-06 3:05 ` [PATCH v2 6/6] target/arm: Fix SVE/SME gross MTE suppression checks Richard Henderson
2024-02-06 14:54 ` Peter Maydell
2024-02-06 14:54 ` [PATCH v2 0/6] target/arm: assorted mte fixes Peter Maydell
2024-02-06 20:10 ` Richard Henderson
2024-02-06 15:17 ` Gustavo Romero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=013d6bb4-1021-4c33-8b03-dc01a62d8c03@linaro.org \
--to=richard.henderson@linaro.org \
--cc=gustavo.romero@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).