From: "Chen HanXiao" <chenhanxiao@cn.fujitsu.com>
To: 'Christoph Hellwig' <hch@lst.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Use SCSI command to get size of SG device
Date: Wed, 10 Oct 2012 10:11:33 +0800 [thread overview]
Message-ID: <014001cda68c$94a58480$bdf08d80$@cn.fujitsu.com> (raw)
In-Reply-To: <20121009172100.GA23380@lst.de>
Hi
> -----Original Message-----
> From: Christoph Hellwig [mailto:hch@lst.de]
> Sent: Wednesday, October 10, 2012 1:21 AM
> To: Chen HanXiao
> Cc: qemu-devel@nongnu.org
> Subject: Re: [Qemu-devel] [PATCH] Use SCSI command to get size of SG
device
>
> On Tue, Oct 09, 2012 at 05:42:01PM +0800, Chen HanXiao wrote:
> > When we use SCSI generic device as disk image, function lseek could
> > not get the size of this kind of device.
> > So try to use SCSI command Read Capacity(10) when lseek failed to get
> > the size of SCSI generic device.
>
> Eww, this is ugly as hell. Why would you even need the size for a raw
> passthrough device?
If we want to enable snapshot for SCSI generic device as disk image, the
size of
SCSI generic device is needed. Function lseek could not get this, SCSI
command
can finish the job.
Only when lseek failed would Read Capacity command be sent.
Regards
next prev parent reply other threads:[~2012-10-10 2:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-09 9:42 [Qemu-devel] [PATCH] Use SCSI command to get size of SG device Chen HanXiao
2012-10-09 17:21 ` Christoph Hellwig
2012-10-10 2:11 ` Chen HanXiao [this message]
2012-10-10 6:33 ` Paolo Bonzini
2012-10-10 8:33 ` Chen HanXiao
2012-10-10 9:01 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='014001cda68c$94a58480$bdf08d80$@cn.fujitsu.com' \
--to=chenhanxiao@cn.fujitsu.com \
--cc=hch@lst.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).