From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 13556C4332F for ; Thu, 17 Nov 2022 20:44:09 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ovlj3-0003vr-7f; Thu, 17 Nov 2022 15:43:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovlj0-0003uw-Ik; Thu, 17 Nov 2022 15:43:06 -0500 Received: from mail.aperture-labs.org ([195.191.197.3]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1ovliw-0001MB-Ul; Thu, 17 Nov 2022 15:43:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fiebig.nl; s=key01; t=1668717778; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NqZIZ+4F677GnhDktopoAp/dCJzU6WcKRRzBGCJPby4=; b=HyW93bLfGLLJUTJLJkz6TP2DYQkl/+dMRi7YMKJ1TtKpqgtWaNhRRXfcRu8NaGtlQbDZew lB8r0EB+yMyMBEIYa+AxwPUbWUqOzkWmgqZLnSa8GHf42vakNOquaxOXd1rLfmBJ/bW7XJ KG2fy7BGa4bbM6bgxoclJHDq+BrDrGf16o61AzN9ltc30ejIo148nmIyAyrdmXWiN1zFsW 5KejpEARFoRNdZYeTIzN+SaTcVj7al6lzHZfATy7FBr1h9qMeyWmr3vK4sHIC0SZRD0DzF XCuSi6oWIIAKQW1ueN3Pptrx40FiRytPbJhr360HAkoldYyvM4GDdAmhmM4ddg== Received: from DESKTOP1J9BJ88 ( [2a06:d1c1:a:0:d0f7:15f4:7842:c716]) by mail.aperture-labs.org (OpenSMTPD) with ESMTPSA id 3ea490fe (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Thu, 17 Nov 2022 20:42:58 +0000 (UTC) From: "Tobias Fiebig" To: "'Stefan Hajnoczi'" Cc: "'Jason Wang'" , "'Stefan Hajnoczi'" , , , "'Russell King - ARM Linux'" References: <20221115163659.1595865-1-stefanha@redhat.com> <011801d8f967$5dad0f00$19072d00$@fiebig.nl> <008c01d8f9ad$6ba58e20$42f0aa60$@fiebig.nl> <01e701d8fa2f$4124d750$c36e85f0$@fiebig.nl> <004f01d8fa77$80cfe4b0$826fae10$@fiebig.nl> In-Reply-To: Subject: RE: [PATCH for-7.2] rtl8139: honor large send MSS value Date: Thu, 17 Nov 2022 21:42:56 +0100 Message-ID: <014101d8fac5$2cad8420$86088c60$@fiebig.nl> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQIsokZAyfqueh54+bOmp3YoqNF9QAEWPJjQAkWwLFsBcAFz4wIIdbmQApZ4LIEBfw6SlgLLtpjbAdQe+jcCVrR9/60NN4gQ Content-Language: en-nl Received-SPF: pass client-ip=195.191.197.3; envelope-from=tobias@fiebig.nl; helo=mail.aperture-labs.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Heho, I gave v3 a shot and it performs as expected; For a requested MSS of = 1320, TSO consistently uses a 1308 MSS. So for me, this patch works. = Thanks for fixing this. :-) Sadly, I do not have boxes to test with .1q around; If none of you has = either, and that should be tested as well, I can give it a shot in the = coming days, but it might take some time. Side note: I found the 'missing' 12b in 12b of TCP options being added. = :-| So sorry for that noise. With best regards, Tobias MTU1500 RTL8139: +++ C+ mode offloaded task TSO IP data 7272 frame data 7292 = specified MSS=3D1448 RTL8139: +++ C+ mode offloaded task TSO IP data 8720 frame data 8740 = specified MSS=3D1448 RTL8139: +++ C+ mode offloaded task TSO IP data 8720 frame data 8740 = specified MSS=3D1448 RTL8139: +++ C+ mode offloaded task TSO IP data 10168 frame data 10188 = specified MSS=3D1448 MTU1320 RTL8139: +++ C+ mode offloaded task TSO IP data 2648 frame data 2668 = specified MSS=3D1308 RTL8139: +++ C+ mode offloaded task TSO IP data 10496 frame data 10516 = specified MSS=3D1308 RTL8139: +++ C+ mode offloaded task TSO IP data 6572 frame data 6592 = specified MSS=3D1308 RTL8139: +++ C+ mode offloaded task TSO IP data 6572 frame data 6592 = specified MSS=3D1308