From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46495) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ejuOu-0004v2-3Q for qemu-devel@nongnu.org; Thu, 08 Feb 2018 17:10:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ejuOp-00023M-88 for qemu-devel@nongnu.org; Thu, 08 Feb 2018 17:10:40 -0500 Received: from mail-it0-x244.google.com ([2607:f8b0:4001:c0b::244]:33400) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ejuOp-00022s-3w for qemu-devel@nongnu.org; Thu, 08 Feb 2018 17:10:35 -0500 Received: by mail-it0-x244.google.com with SMTP id u12so979664ite.0 for ; Thu, 08 Feb 2018 14:10:35 -0800 (PST) References: <20180208173157.24705-1-alex.bennee@linaro.org> <20180208173157.24705-17-alex.bennee@linaro.org> From: Richard Henderson Message-ID: <01476a36-ea99-e11b-ce2c-8752cc6e8b2c@linaro.org> Date: Thu, 8 Feb 2018 14:10:31 -0800 MIME-Version: 1.0 In-Reply-To: <20180208173157.24705-17-alex.bennee@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v2 16/32] arm/translate-a64: add FP16 x2 ops for simd_indexed List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Alex_Benn=c3=a9e?= , qemu-arm@nongnu.org Cc: Peter Maydell , qemu-devel@nongnu.org On 02/08/2018 09:31 AM, Alex Bennée wrote: > A bunch of the vectorised bitwise operations just operate on larger > chunks at a time. We can do the same for the new half-precision > operations by introducing some TWOHALFOP helpers which work on each > half of a pair of half-precision operations at once. > > Hopefully all this hoop jumping will get simpler once we have > generically vectorised helpers here. > > Signed-off-by: Alex Bennée > > --- > v2 > - checkpatch fixes > --- > target/arm/helper-a64.c | 46 +++++++++++++++++++++++++++++++++++++++++++++- > target/arm/helper-a64.h | 10 ++++++++++ > target/arm/translate-a64.c | 36 +++++++++++++++++++++++++++++------- > 3 files changed, 84 insertions(+), 8 deletions(-) Reviewed-by: Richard Henderson r~