From: Pavel Fedin <p.fedin@samsung.com>
To: "'Michael S. Tsirkin'" <mst@redhat.com>
Cc: 'Paolo Bonzini' <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/3] Make KVM/MSI code device-ID-aware
Date: Tue, 13 Oct 2015 16:49:17 +0300 [thread overview]
Message-ID: <014801d105bd$f4d8c5e0$de8a51a0$@samsung.com> (raw)
In-Reply-To: <20151013155711-mutt-send-email-mst@redhat.com>
Hello!
> I'm not at all sure we want to keep extending pci-assign with
> more functionality. Why not add it to vfio instead?
pci-assign? What exactly do you mean?
hw/i386/kvm/pci-assign.c is modified only because kvm_irqchip_add_msi_route() now wants pci_dev pointer. Since x86 platform doesn't
use device IDs, it could very well be NULL. Just i decided to keep it consistent with the rest of the code.
Actually, patch 0003 is all about that - we add pci_dev pointer to KVM GSI routing functions and make callers passing it, that's
all. Currently it's not used because KVM API is not released yet. See my full vITS patchset for information on how it will be used.
And yes, the patchset is a bit obsolete, so it doesn't have msi_device_id() inline, there's copypasted calculation instead.
What exactly do you suggest to move to vfio?
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
next prev parent reply other threads:[~2015-10-13 13:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-13 12:11 [Qemu-devel] [PATCH 0/3] Make KVM/MSI code device-ID-aware Pavel Fedin
2015-10-13 12:12 ` [Qemu-devel] [PATCH 1/3] kvm: Make KVM_CAP_SIGNAL_MSI globally available Pavel Fedin
2015-10-13 12:12 ` [Qemu-devel] [PATCH 2/3] hw/pci: Introduce msi_device_id() Pavel Fedin
2015-10-13 12:56 ` Michael S. Tsirkin
2015-10-13 13:24 ` Pavel Fedin
2015-10-13 12:12 ` [Qemu-devel] [PATCH 3/3] kvm: Pass PCI device pointer to MSI routing functions Pavel Fedin
2015-10-13 13:00 ` [Qemu-devel] [PATCH 0/3] Make KVM/MSI code device-ID-aware Michael S. Tsirkin
2015-10-13 13:49 ` Pavel Fedin [this message]
2015-10-13 14:03 ` Michael S. Tsirkin
2015-10-13 15:17 ` Pavel Fedin
2015-10-13 15:58 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='014801d105bd$f4d8c5e0$de8a51a0$@samsung.com' \
--to=p.fedin@samsung.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).