From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40558)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <p.fedin@samsung.com>) id 1ZlzxF-0007UN-U4
	for qemu-devel@nongnu.org; Tue, 13 Oct 2015 09:49:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <p.fedin@samsung.com>) id 1ZlzxB-0004gD-Vd
	for qemu-devel@nongnu.org; Tue, 13 Oct 2015 09:49:25 -0400
Received: from mailout3.w1.samsung.com ([210.118.77.13]:23179)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <p.fedin@samsung.com>) id 1ZlzxB-0004fz-PT
	for qemu-devel@nongnu.org; Tue, 13 Oct 2015 09:49:21 -0400
Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244])
	by mailout3.w1.samsung.com
	(Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5
	2014)) with ESMTP id <0NW5006Y1VQ7BG40@mailout3.w1.samsung.com> for
	qemu-devel@nongnu.org; Tue, 13 Oct 2015 14:49:19 +0100 (BST)
From: Pavel Fedin <p.fedin@samsung.com>
References: <cover.1444737974.git.p.fedin@samsung.com>
	<20151013155711-mutt-send-email-mst@redhat.com>
In-reply-to: <20151013155711-mutt-send-email-mst@redhat.com>
Date: Tue, 13 Oct 2015 16:49:17 +0300
Message-id: <014801d105bd$f4d8c5e0$de8a51a0$@samsung.com>
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii
Content-transfer-encoding: 7bit
Content-language: ru
Subject: Re: [Qemu-devel] [PATCH 0/3] Make KVM/MSI code device-ID-aware
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "'Michael S. Tsirkin'" <mst@redhat.com>
Cc: 'Paolo Bonzini' <pbonzini@redhat.com>, qemu-devel@nongnu.org

 Hello!

> I'm not at all sure we want to keep extending pci-assign with
> more functionality. Why not add it to vfio instead?

 pci-assign? What exactly do you mean?

 hw/i386/kvm/pci-assign.c is modified only because kvm_irqchip_add_msi_route() now wants pci_dev pointer. Since x86 platform doesn't
use device IDs, it could very well be NULL. Just i decided to keep it consistent with the rest of the code.
 Actually, patch 0003 is all about that - we add pci_dev pointer to KVM GSI routing functions and make callers passing it, that's
all. Currently it's not used because KVM API is not released yet. See my full vITS patchset for information on how it will be used.
And yes, the patchset is a bit obsolete, so it doesn't have msi_device_id() inline, there's copypasted calculation instead.
 What exactly do you suggest to move to vfio?

Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia