From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39493)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Pavel.Dovgaluk@ispras.ru>) id 1X2I0h-0001KT-CU
	for qemu-devel@nongnu.org; Wed, 02 Jul 2014 06:43:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Pavel.Dovgaluk@ispras.ru>) id 1X2I0Z-00051u-RI
	for qemu-devel@nongnu.org; Wed, 02 Jul 2014 06:43:31 -0400
Received: from mail.ispras.ru ([83.149.199.45]:51784)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Pavel.Dovgaluk@ispras.ru>) id 1X2I0Z-00051X-Jq
	for qemu-devel@nongnu.org; Wed, 02 Jul 2014 06:43:23 -0400
From: "Pavel Dovgaluk" <Pavel.Dovgaluk@ispras.ru>
References: <007c01cf951e$ea84e850$bf8eb8f0$@Dovgaluk@ispras.ru>
	<53B2F0CC.6010001@redhat.com>
In-Reply-To: <53B2F0CC.6010001@redhat.com>
Date: Wed, 2 Jul 2014 14:43:23 +0400
Message-ID: <014b01cf95e2$72e3e840$58abb8c0$@Dovgaluk@ispras.ru>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="UTF-8"
Content-Transfer-Encoding: 7bit
Content-Language: ru
Subject: Re: [Qemu-devel] [RFC PATCH 08/22] Monitor commands
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: 'Eric Blake' <eblake@redhat.com>, 'QEMU Developers' <qemu-devel@nongnu.org>

> -----Original Message-----
> From: Eric Blake [mailto:eblake@redhat.com]
> Sent: Tuesday, July 01, 2014 9:33 PM
> To: Pavel Dovgaluk; 'QEMU Developers'
> Subject: Re: [Qemu-devel] [RFC PATCH 08/22] Monitor commands
> 
> On 07/01/2014 05:23 AM, Pavel Dovgaluk wrote:
> > This patch adds commands to control replay from the monitor.
> >
> > Signed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@gmail.com>
> > ---
> 
> What are the counterpart QMP commands?  It is seldom right to add an HMP
> command unless the same thing can be done via QMP.

We haven't controlled qemu through QMP yet, thus haven't implemented QMP support
for replay commands.

Today I started adding this support and noticed, that QMP in current master branch is
broken - it does not reply anything except information at start.

> > @@ -2596,6 +2734,7 @@ int monitor_handle_fd_param2(Monitor *mon, const char *fdname, Error
> **errp)
> >      return fd;
> >  }
> >
> > +
> >  /* Please update hmp-commands.hx when adding or changing commands */
> >  static mon_cmd_t info_cmds[] = {
> 
> Spurious newline addition?

Thanks, forgot to undo this.

Pavel Dovgaluk