From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38429) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZUEfF-0004Pc-RP for qemu-devel@nongnu.org; Tue, 25 Aug 2015 09:53:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZUEfA-0004IS-Qy for qemu-devel@nongnu.org; Tue, 25 Aug 2015 09:53:25 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:36394) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZUEfA-0004Hp-Ko for qemu-devel@nongnu.org; Tue, 25 Aug 2015 09:53:20 -0400 Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout1.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NTN008BV58S8400@mailout1.w1.samsung.com> for qemu-devel@nongnu.org; Tue, 25 Aug 2015 14:53:16 +0100 (BST) From: Pavel Fedin References: <0f869a8319f484f55b4845d1e8bc4764a8b767d9.1439968813.git.p.fedin@samsung.com> <"20150825134053.GB27329@ashoks"@broadcom.com> In-reply-to: <"20150825134053.GB27329@ashoks"@broadcom.com> Date: Tue, 25 Aug 2015 16:53:15 +0300 Message-id: <015101d0df3d$64754330$2d5fc990$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit Content-language: ru Subject: Re: [Qemu-devel] [PATCH v11 5/5] hw/arm/virt: Add gic-version option to virt machine List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: 'Ashok Kumar' Cc: 'Peter Maydell' , 'Eric Auger' , 'Shlomo Pongratz' , 'Shlomo Pongratz' , qemu-devel@nongnu.org, 'Christoffer Dall' Hello! > In KVM case instead of assigning GICv2 as default, can we probe the KVM > for GICv3 presence using KVM_CREATE_DEVICE_TEST and give priority to > GICv3? We could, but i think this would hurt usability. I suggest that when the user chooses a configuration, he/she expects to get something particular. And IMHO it's much better to default to GICv2 (to be backwards-compatible), and just report error in case if this is not supported by KVM, than to default to something, which is different on different machines and different kernels. Libvirt guys already blame "virt" machine for being too flexible... Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia