From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39158)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <p.fedin@samsung.com>) id 1ZB1BG-0002ur-Gd
	for qemu-devel@nongnu.org; Fri, 03 Jul 2015 09:39:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <p.fedin@samsung.com>) id 1ZB1BC-0003Fa-DZ
	for qemu-devel@nongnu.org; Fri, 03 Jul 2015 09:39:02 -0400
Received: from mailout3.w1.samsung.com ([210.118.77.13]:17197)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <p.fedin@samsung.com>) id 1ZB1BC-0003Dq-7z
	for qemu-devel@nongnu.org; Fri, 03 Jul 2015 09:38:58 -0400
Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244])
	by mailout3.w1.samsung.com
	(Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5
	2014)) with ESMTP id <0NQW00C3GZ8VZ660@mailout3.w1.samsung.com> for
	qemu-devel@nongnu.org; Fri, 03 Jul 2015 14:38:55 +0100 (BST)
From: Pavel Fedin <p.fedin@samsung.com>
References: <017b01d0a809$0f682580$2e387080$@samsung.com>
	<CAEgOgz6uSB_g75yQERNCtE+=MmcQ38nV5hhZriPJuEvOy3gZEw@mail.gmail.com>
	<015e01d0b593$1a754f60$4f5fee20$@samsung.com>
	<55968D1E.9030308@suse.de>
In-reply-to: <55968D1E.9030308@suse.de>
Date: Fri, 03 Jul 2015 16:38:53 +0300
Message-id: <015f01d0b595$9ae33340$d0a999c0$@samsung.com>
MIME-version: 1.0
Content-type: text/plain; charset=UTF-8
Content-transfer-encoding: quoted-printable
Content-language: ru
Subject: Re: [Qemu-devel] [PATCH v3] QOM: object_property_add() performance
 improvement
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?Q?'Andreas_F=C3=A4rber'?= <afaerber@suse.de>, 'Peter Crosthwaite' <peter.crosthwaite@xilinx.com>
Cc: 'QEMU Developers' <qemu-devel@nongnu.org>

 Hello! Thank you very much for your feedback.

> Nack, I don't like the patch as is. Starting with the unoptimized code
> movement combined with functional changes

 Will it be OK if i split it into two parts:
 1. Restructuring, introduction of object_property_add_single()
 2. Introduction of cache property by itself.

> up to the use of [*] for the
> new property iiuc.

 What would you suggest instead? Personally i don't have much =
preferences, i used it just because it was already there.
 What about 'name#' ?

Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia