From: Pavel Fedin <p.fedin@samsung.com>
To: 'Peter Maydell' <peter.maydell@linaro.org>,
'Andrew Jones' <drjones@redhat.com>
Cc: "'QEMU Developers'" <qemu-devel@nongnu.org>,
"'Andreas Färber'" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH 1/2] [RFC] arm_gic_common.h: add gicv2 aliases for defines
Date: Mon, 12 Oct 2015 09:58:12 +0300 [thread overview]
Message-ID: <016001d104bb$5cde8f20$169bad60$@samsung.com> (raw)
In-Reply-To: <CAFEAcA9JnWke=pGFPPcNzC2-hRaiNLZhe4972twd4TeAVJ-pmw@mail.gmail.com>
Hi!
> It looks like the only thing in the gicv3 code that is using
> a define from the arm_gic_common.h file is "GIC_INTERNAL",
> so we can just put a suitable define of that into the v3 header
> (maybe giving it a better name in the process).
Yes, indeed. Actually, first versions of my GICv3 patches did use own #define, but i was criticized for using GICV3_INTERNAL in my code and having GIC_INTERNAL in kvm_arm_gic_set_irq(), which is shared by both KVM implementations. So, i decided to use GIC_INTERNAL everywhere and inherited it from v2.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
next prev parent reply other threads:[~2015-10-12 6:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-06 14:37 [Qemu-devel] [PATCH 0/2] hw/arm/virt: max-cpus init/check fixup Andrew Jones
2015-10-06 14:37 ` [Qemu-devel] [PATCH 1/2] [RFC] arm_gic_common.h: add gicv2 aliases for defines Andrew Jones
2015-10-09 16:41 ` Peter Maydell
2015-10-12 6:58 ` Pavel Fedin [this message]
2015-10-06 14:37 ` [Qemu-devel] [PATCH 2/2] hw/arm/virt: don't use a15memmap directly Andrew Jones
2015-10-09 16:45 ` Peter Maydell
2015-10-09 17:05 ` Andrew Jones
2015-10-12 7:00 ` Pavel Fedin
2015-10-12 12:07 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='016001d104bb$5cde8f20$169bad60$@samsung.com' \
--to=p.fedin@samsung.com \
--cc=afaerber@suse.de \
--cc=drjones@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).