From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43966)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <p.fedin@samsung.com>) id 1ZlX3t-0004ks-W6
	for qemu-devel@nongnu.org; Mon, 12 Oct 2015 02:58:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <p.fedin@samsung.com>) id 1ZlX3q-0004KX-Ps
	for qemu-devel@nongnu.org; Mon, 12 Oct 2015 02:58:21 -0400
Received: from mailout3.w1.samsung.com ([210.118.77.13]:59712)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <p.fedin@samsung.com>) id 1ZlX3q-0004J8-KL
	for qemu-devel@nongnu.org; Mon, 12 Oct 2015 02:58:18 -0400
Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244])
	by mailout3.w1.samsung.com
	(Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5
	2014)) with ESMTP id <0NW300888I116060@mailout3.w1.samsung.com> for
	qemu-devel@nongnu.org; Mon, 12 Oct 2015 07:58:13 +0100 (BST)
From: Pavel Fedin <p.fedin@samsung.com>
References: <1444142228-6696-1-git-send-email-drjones@redhat.com>
	<1444142228-6696-2-git-send-email-drjones@redhat.com>
	<CAFEAcA9JnWke=pGFPPcNzC2-hRaiNLZhe4972twd4TeAVJ-pmw@mail.gmail.com>
In-reply-to: <CAFEAcA9JnWke=pGFPPcNzC2-hRaiNLZhe4972twd4TeAVJ-pmw@mail.gmail.com>
Date: Mon, 12 Oct 2015 09:58:12 +0300
Message-id: <016001d104bb$5cde8f20$169bad60$@samsung.com>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-transfer-encoding: quoted-printable
Content-language: ru
Subject: Re: [Qemu-devel] [PATCH 1/2] [RFC] arm_gic_common.h: add
 gicv2	aliases for defines
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: 'Peter Maydell' <peter.maydell@linaro.org>, 'Andrew Jones' <drjones@redhat.com>
Cc: 'QEMU Developers' <qemu-devel@nongnu.org>, =?utf-8?Q?'Andreas_F=C3=A4rber'?= <afaerber@suse.de>

 Hi!

> It looks like the only thing in the gicv3 code that is using
> a define from the arm_gic_common.h file is "GIC_INTERNAL",
> so we can just put a suitable define of that into the v3 header
> (maybe giving it a better name in the process).

 Yes, indeed. Actually, first versions of my GICv3 patches did use own =
#define, but i was criticized for using GICV3_INTERNAL in my code and =
having GIC_INTERNAL in kvm_arm_gic_set_irq(), which is shared by both =
KVM implementations. So, i decided to use GIC_INTERNAL everywhere and =
inherited it from v2.

Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia