From: Pavel Fedin <p.fedin@samsung.com>
To: 'Shlomo Pongratz' <shlomopongratz@gmail.com>
Cc: peter.maydell@linaro.org, eric.auger@linaro.org,
'Shlomo Pongratz' <shlomo.pongratz@huawei.com>,
qemu-devel@nongnu.org, shannon.zhao@linaro.org,
ashoks@broadcom.com, imammedo@redhat.com
Subject: Re: [Qemu-devel] [PATCH RFC V5 1/9] hw/intc: Implement GIC-500 support files
Date: Wed, 21 Oct 2015 16:39:15 +0300 [thread overview]
Message-ID: <016b01d10c05$e1762080$a4626180$@samsung.com> (raw)
In-Reply-To: <CAHzK-V3akMrRha9dHsS2pZQzzM3RFY8FSwkAQSnyR+yr6n0H0g@mail.gmail.com>
Hello!
> Do you mean that in virt.c::create_gic I'll take the cpu's affinity from the cpu's property and not directly from
> ARM_CPU(qemu_get_cpu(i))->mp_affinity
I mean that you can do it in your GIC's realize function. And, even better, in arm_gicv3_common_realize(), because KVM GICv3 live migration code will also need it:
--- cut ---
for (i = 0; i < s->num_cpu; i++) {
Object *cpu = OBJECT(qemu_get_cpu(i));
s->cpu[i].mp_affinity = object_property_get_int(cpu, "mp-affinity", NULL);
}
--- cut ---
> I can do that but that depends on acceptance of your patch.
Peter ACKed it, just he doesn't like having unused code: http://lists.nongnu.org/archive/html/qemu-devel/2015-10/msg03105.html
Just include it into your next respin and forget. :) Actually, i made my RFC so that you could just take 0001 and 0002 from it and use for your purpose. With additions, of course, if necessary.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
next prev parent reply other threads:[~2015-10-21 13:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1445396964-21189-1-git-send-email-shlomopongratz@gmail.com>
2015-10-21 6:48 ` [Qemu-devel] [PATCH RFC V5 1/9] hw/intc: Implement GIC-500 support files Pavel Fedin
[not found] ` <CAHzK-V0YsPx8E66fNpJ7C6T=tE-CM-pg2o5vQNpYn1SQ4BeLxg@mail.gmail.com>
2015-10-21 10:48 ` Pavel Fedin
2015-10-21 11:38 ` Shlomo Pongratz
2015-10-21 12:32 ` Pavel Fedin
2015-10-21 13:12 ` Shlomo Pongratz
2015-10-21 13:39 ` Pavel Fedin [this message]
2015-10-21 13:58 ` Shlomo Pongratz
2015-10-20 17:22 [Qemu-devel] [PATCH RFC V5 0/9] Implement GIC-500 from GICv3 family for arm64 Shlomo Pongratz
[not found] ` <1445361732-16257-2-git-send-email-shlomopongratz@gmail.com>
2015-10-22 11:53 ` [Qemu-devel] [PATCH RFC V5 1/9] hw/intc: Implement GIC-500 support files Pavel Fedin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='016b01d10c05$e1762080$a4626180$@samsung.com' \
--to=p.fedin@samsung.com \
--cc=ashoks@broadcom.com \
--cc=eric.auger@linaro.org \
--cc=imammedo@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=shannon.zhao@linaro.org \
--cc=shlomo.pongratz@huawei.com \
--cc=shlomopongratz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).