From: Pavel Fedin <p.fedin@samsung.com>
To: 'Peter Maydell' <peter.maydell@linaro.org>
Cc: 'Shlomo Pongratz' <shlomo.pongratz@huawei.com>,
'Shlomo Pongratz' <shlomopongratz@gmail.com>,
'QEMU Developers' <qemu-devel@nongnu.org>,
'Christoffer Dall' <christoffer.dall@linaro.org>,
'Eric Auger' <eric.auger@linaro.org>
Subject: Re: [Qemu-devel] [PATCH v8 3/5] Introduce irqchip type specification for KVM
Date: Wed, 12 Aug 2015 15:27:32 +0300 [thread overview]
Message-ID: <017f01d0d4fa$43cf3570$cb6da050$@samsung.com> (raw)
In-Reply-To: <CAFEAcA9Y7s0ChPnrv48JQxZrG3rHXtck8rHndYznZEMSCigQbw@mail.gmail.com>
Hello!
> I still think this is the wrong approach -- see my remarks
> in the previous round of patch review.
You know... I thought a little bit...
So far, test = true in KVM_CREATE_DEVICE means that we just want to know whether this type is supported. No actual actions is done by the kernel. Is it correct? If yes, we can just leave this test as it is, because if it says that GICv2 is supported by KVM_CREATE_DEVICE, then:
1. We use new API. No KVM_IRQCHIP_CREATE.
2. GICv3 may be supported.
Therefore, if we do this check, and it succeeds, then we just proceed, and later actually try to create GICv3. If it fails for some reason, we will see error message anyway. So would it be OK just not to touch kvm_arch_irqchip_create() at all?
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
next prev parent reply other threads:[~2015-08-12 12:27 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-10 12:06 [Qemu-devel] [PATCH v8 0/5] vGICv3 support Pavel Fedin
2015-08-10 12:06 ` [Qemu-devel] [PATCH v8 1/5] Implement GIC-500 base class Pavel Fedin
2015-08-10 17:23 ` Peter Maydell
2015-08-11 7:53 ` Pavel Fedin
2015-08-11 9:20 ` Peter Maydell
2015-08-11 9:35 ` Pavel Fedin
2015-08-11 10:15 ` Peter Maydell
2015-08-11 10:39 ` Pavel Fedin
2015-08-11 10:42 ` Peter Maydell
2015-08-10 12:06 ` [Qemu-devel] [PATCH v8 2/5] Extract some reusable vGIC code Pavel Fedin
2015-08-10 17:34 ` Peter Maydell
2015-08-11 7:23 ` Pavel Fedin
2015-08-10 12:06 ` [Qemu-devel] [PATCH v8 3/5] Introduce irqchip type specification for KVM Pavel Fedin
2015-08-10 16:45 ` Peter Maydell
2015-08-12 11:44 ` Pavel Fedin
2015-08-12 11:45 ` Christoffer Dall
2015-08-12 12:27 ` Pavel Fedin [this message]
2015-08-12 12:59 ` Peter Maydell
2015-08-12 13:23 ` Christoffer Dall
2015-08-12 14:14 ` Eric Auger
2015-08-12 14:24 ` Christoffer Dall
2015-08-12 15:21 ` Eric Auger
2015-08-10 12:06 ` [Qemu-devel] [PATCH v8 4/5] Initial implementation of vGICv3 Pavel Fedin
2015-08-10 17:18 ` Peter Maydell
2015-08-10 12:06 ` [Qemu-devel] [PATCH v8 5/5] Add gicversion option to virt machine Pavel Fedin
2015-08-10 17:12 ` Peter Maydell
2015-08-13 11:02 ` Pavel Fedin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='017f01d0d4fa$43cf3570$cb6da050$@samsung.com' \
--to=p.fedin@samsung.com \
--cc=christoffer.dall@linaro.org \
--cc=eric.auger@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=shlomo.pongratz@huawei.com \
--cc=shlomopongratz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).